Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ui_filters API endpoints #90900

Merged
merged 8 commits into from
Feb 16, 2021
Merged

Move ui_filters API endpoints #90900

merged 8 commits into from
Feb 16, 2021

Conversation

smith
Copy link
Contributor

@smith smith commented Feb 10, 2021

  • Move /ui_filters/environments to /environments
  • Move other ui_filters endpoint to UX directories

References #84526.

@smith smith marked this pull request as ready for review February 10, 2021 23:09
@smith smith requested review from a team as code owners February 10, 2021 23:09
@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Feb 11, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@smith
Copy link
Contributor Author

smith commented Feb 11, 2021

@elasticmachine merge upstream

@smith smith added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0 labels Feb 11, 2021
shahzad31
shahzad31 approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Looks good !!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.2MB 5.2MB -30.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit bef5674 into elastic:master Feb 16, 2021
@smith smith deleted the nls/api-moves branch February 16, 2021 22:37
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 16, 2021
@smith @kibanamachine
Move ui_filters API endpoints (elastic#90900)
1d7b534
@kibanamachine kibanamachine mentioned this pull request Feb 16, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.x / #91582

Successful backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Feb 17, 2021
@kibanamachine @smith
Move ui_filters API endpoints (#90900) (#91582)
fe8ae31 
Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
sorenlouv
sorenlouv reviewed Feb 17, 2021
View reviewed changes
x-pack/plugins/apm/server/lib/environments/get_all_environments.ts
/**
* This is used for getting *all* environments, and does not filter by range.
* It's used in places where we get the list of all possible environments.
*/
export async function getAllEnvironments({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to rename it to dangerousGetEnvironmentsSinceBeginningOfTime to highlight this

@smith smith mentioned this pull request Feb 19, 2021
Closed
8 tasks
@shahzad31 shahzad31 mentioned this pull request Jun 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smith @elasticmachine @kibanamachine @sorenlouv @shahzad31