-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes session idle timeout #91070
Merged
jportner
merged 15 commits into
elastic:master
from
jportner:issue-91014-fix-session-idle-timeout
Feb 16, 2021
Merged
Fixes session idle timeout #91070
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
91ce799
Fix calls to `/api/saved_objects_tagging/tags`
jportner f9d1fc0
Fix calls to `/api/ui_counters/_report`
jportner 4028d8d
Fix calls to `/api/index_management/indices/reload`
jportner 8006eb7
Fix calls to `/api/watcher/watches`
jportner 4561057
Fix calls to `/api/rollup/jobs`
jportner d549970
Fix calls to `/api/cross_cluster_replication/follower_indices`
jportner 28e1cc6
Fix calls to `/api/cross_cluster_replication/auto_follow_patterns`
jportner e756e91
Fix calls to `/api/transform/transforms` and `/api/transform/transfor…
jportner c7b4a55
Merge branch 'master' into pr/jportner/91070
jportner ea21930
Fix calls to `/api/console/proxy`
jportner 623b447
Fix calls to `/api/monitoring/v1/clusters` and `/api/monitoring/v1/el…
jportner f8e20f6
Merge branch 'master' into issue-91014-fix-session-idle-timeout
kibanamachine e495677
Merge branch 'master' into pr/jportner/91070
jportner 89f3df8
PR review feedback
jportner 1ef7e5a
More PR review feedback
jportner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -19,10 +19,14 @@ export interface TagAttributes { | |||
color: string; | ||||
} | ||||
|
||||
export interface GetAllTagsOptions { | ||||
asSystemRequest?: boolean; | ||||
} | ||||
|
||||
export interface ITagsClient { | ||||
create(attributes: TagAttributes): Promise<Tag>; | ||||
get(id: string): Promise<Tag>; | ||||
getAll(): Promise<Tag[]>; | ||||
getAll(options?: GetAllTagsOptions): Promise<Tag[]>; | ||||
Comment on lines
-25
to
+29
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This interface is also used by the server-side
and I think this option doesn't make any sense on the server. But refactoring the code to use distinct interfaces is probably going to be a pain, so I'm ok keeping these changes for now as we do want that for |
||||
delete(id: string): Promise<void>; | ||||
update(id: string, attributes: TagAttributes): Promise<Tag>; | ||||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to extract the parameter from
UseRequestConfig
above in theuseRequest
call and use it here. As we are not passing it on L120 and we don't want the consumer to change the request configuration when callingresendRequest
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the terrible diff here, all I did was 1. add an
asSystemRequest
parameter to the anonymous callback function, and 2. construct the request payload using this new parameter.Actually I don't think we want to expose this in
UseRequestConfig
-- I see it as an implementation detail. A consumer calls theuseRequest
function, which schedules itself to poll in the background. Consumers should not be able to determine whether this is treated as a system request. It's background polling, so it must be treated as such.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I understand. But then when we provide that handler to the consumer should we protect it and set to
false
on L145, or is it overkill?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, now I understand now what you were trying to say 😄
It's not something we need to protect. As in, there's no danger of other unintended consequences if a consumer happened to use this parameter.
However, we don't have any consumers that require the ability to use this when manually requesting data. With that in mind, I think we should apply your suggestion until we have a reason to expose it.
Edit: changed in 1ef7e5a.