ship @kbn/ui-shared-deps metrics in separate step #91504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
mistic
reviewed
Feb 16, 2021
|
Pinging @elastic/kibana-operations (Team:Operations) |
mistic
approved these changes
Feb 16, 2021
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
spalger
added
the
auto-backport
💔 Backport failed❌ 7.x: Commit could not be cherrypicked due to conflicts To backport manually, check out the target branch and run: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #90482 we added
node scripts/ship_ci_statswith the intention of separating CI stats generation from shipping so that we would be able to cache the package build output with Bazel but reliably ship metrics in CI (by not caching those steps). This extends that logic to@kbn/ui-shared-depsby writing the metrics to themetrics.jsonfile in the target dir of that package and then shipping them in a followup command withinsrc/dev/ci_setup/setup.sh.