Use doc link service in Upgrade Assistant #91573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcawl
added
Feature:Upgrade Assistant
release_note:skip
alisonelizabeth
added
the
Team:Kibana Management
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
alisonelizabeth
approved these changes
Feb 17, 2021
There was a problem hiding this comment.
Change LGTM. Thanks for addressing this and removing the //eslint-disable @lcawl!
I have two quick questions (not blocking) -
- I think there are other doc links in Upgrade Assistant. Are you only migrating links that are already defined in the doc links service?
- I just want to confirm this change is still intended for
7.12given FF was yesterday?
I am just fixing the ones I find via search, but if there are others I'm happy to help with those too.
Ah, if I've missed that date I'll just wait and merge into 7.x after the branching. |
lcawl
added a commit
to lcawl/kibana
that referenced
this pull request
Feb 17, 2021
lcawl
added a commit
that referenced
this pull request
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #88107
This PR removes a hard-coded link and replaces it with a keyword from the documentation link service