Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.8] Fixes session timeout (#91070) #91888

Merged
merged 7 commits into from
Feb 19, 2021
Merged

Conversation

jportner
Copy link
Contributor

This is a manual backport of #91070. Kibana has been refactored quite a bit since 6.8, so I had to fix each page by hand.

Commits from the original PR that I did NOT include in this backport:

  • Fix calls to /api/saved_objects_tagging/tags - Saved Objects Tagging does not exist in 6.8.
  • Fix calls to /api/ui_counters/_report - Usage data reporting does not exist in 6.8.
  • Fix calls to /api/transform/transforms and /api/transform/transforms/_stats - There is no Transforms page in the Management app in 6.8.
  • Fix calls to /api/console/proxy - Dev Tools in 6.8 does not use the Angular HTTP client, so the session timeout interceptors don't work on that page. This means that sessions never get extended because of these background calls.

…asticsearch_settings/check/cluster`

Seen on page: /app/monitoring
Seen on page: /app/kibana#/management/elasticsearch/index_management/indices
Seen on page: /app/kibana#/management/elasticsearch/cross_cluster_replication/follower_indices
Seen on page: /app/kibana#/management/elasticsearch/cross_cluster_replication/auto_follow_patterns
Seen on page: /app/kibana#/management/elasticsearch/remote_clusters/list
Seen on page: /app/kibana#/management/elasticsearch/watcher/watches
Seen on page: /app/kibana#/management/elasticsearch/rollup_jobs/job_list
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I tested manually briefly, and everything looked good to me.

@jportner jportner merged commit 9297226 into elastic:6.8 Feb 19, 2021
@jportner jportner deleted the fix-session-timeout branch February 19, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants