[Security Solution][Case][Bug] Allowing deletion of collections #91926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-buttner
added
v8.0.0
release_note:skip
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
This was referenced Feb 18, 2021
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
XavierM
approved these changes
Feb 19, 2021
jonathan-buttner
added a commit
to jonathan-buttner/kibana
that referenced
this pull request
Feb 19, 2021
jonathan-buttner
added a commit
that referenced
this pull request
Feb 19, 2021
jonathan-buttner
added a commit
that referenced
this pull request
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows deletion of case collections instead of restricting it. The danger of deleting a collection is that when a detection rule fires it will not be able to add the generated alerts to a sub case under the collection. We decided allowing deletions would be better to give the user more control. If a collection is deleted that is being used by a rule, when the rule fires we will log an error about not being able to find the collection and fail silently.
The logging will be handled in this PR: #91924