Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch-up release documentation #92411

Merged
merged 8 commits into from
Feb 23, 2021
Merged

Catch-up release documentation #92411

merged 8 commits into from
Feb 23, 2021

Conversation

mikecote
Copy link
Contributor

@mikecote mikecote added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.11.0 v7.12.0 v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Feb 23, 2021
@mikecote mikecote requested review from gchaps and a team February 23, 2021 14:01
@mikecote mikecote self-assigned this Feb 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

ymao1
ymao1 approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmmorris
gmmorris approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@gmmorris gmmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gchaps
gchaps reviewed Feb 23, 2021
View reviewed changes
docs/api/actions-and-connectors/create.asciidoc
@@ -28,6 +28,8 @@ Creates an action.
(Required, object) The secrets configuration for the action. Secrets configuration properties vary
depending on the action type. For information about the secrets configuration properties, refer to <<action-types,Action and connector types>>.

WARNING: Remember these values. You must provide them each time you call the <<actions-and-connectors-api-update, update>> API.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this note is specific to secrets, then it should be indented under secrets. Adding a "+" to the blank line above the warning should do the trick.

Copy link
Contributor Author

@mikecote mikecote Feb 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct because it is specific to secrets. Adding + to the line above worked, thanks! Fixed in b24a4b1 ready for re-review.

docs/user/alerting/action-types/email.asciidoc Outdated Show resolved Hide resolved
docs/user/alerting/alerting-getting-started.asciidoc Outdated Show resolved Hide resolved
mikecote and others added 4 commits February 23, 2021 10:56
@mikecote @gchaps
Update docs/user/alerting/action-types/email.asciidoc
183531b 
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@mikecote @gchaps
Update docs/user/alerting/alerting-getting-started.asciidoc
e28798e 
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@mikecote
Indent warning
b24a4b1
@mikecote
Merge branch 'alerting/docs-catch-up' of github.com:mikecote/kibana i…
21e0d67 
…nto alerting/docs-catch-up
@mikecote mikecote requested a review from gchaps February 23, 2021 16:01
gchaps
gchaps approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikecote mikecote merged commit b337d49 into elastic:master Feb 23, 2021
@kibanamachine kibanamachine mentioned this pull request Feb 23, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 23, 2021
@mikecote @gchaps @kibanamachine
Catch-up release documentation (elastic#92411)
57b8229 
* Initial commit

* Undo custom id docs (done in separate PR)

* Update docs, a bit

* fix create api doc

* Update docs/user/alerting/action-types/email.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/user/alerting/alerting-getting-started.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Indent warning

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 23, 2021
@mikecote @gchaps @kibanamachine
Catch-up release documentation (elastic#92411)
a0f5d3d 
* Initial commit

* Undo custom id docs (done in separate PR)

* Update docs, a bit

* fix create api doc

* Update docs/user/alerting/action-types/email.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/user/alerting/alerting-getting-started.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Indent warning

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Feb 23, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 23, 2021
@mikecote @gchaps @kibanamachine
Catch-up release documentation (elastic#92411)
c8c6728 
* Initial commit

* Undo custom id docs (done in separate PR)

* Update docs, a bit

* fix create api doc

* Update docs/user/alerting/action-types/email.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/user/alerting/alerting-getting-started.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Indent warning

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Feb 23, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.11 / #92452
✅ 7.12 / #92453
✅ 7.x / #92454

Successful backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Feb 23, 2021
@kibanamachine @mikecote @gchaps
Catch-up release documentation (#92411) (#92452)
04b071b 
* Initial commit

* Undo custom id docs (done in separate PR)

* Update docs, a bit

* fix create api doc

* Update docs/user/alerting/action-types/email.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/user/alerting/alerting-getting-started.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Indent warning

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: Mike Côté <mikecote@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Feb 23, 2021
@kibanamachine @mikecote @gchaps
Catch-up release documentation (#92411) (#92453)
4f65a5a 
* Initial commit

* Undo custom id docs (done in separate PR)

* Update docs, a bit

* fix create api doc

* Update docs/user/alerting/action-types/email.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/user/alerting/alerting-getting-started.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Indent warning

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: Mike Côté <mikecote@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Feb 23, 2021
@kibanamachine @mikecote @gchaps
Catch-up release documentation (#92411) (#92454)
8fa702c 
* Initial commit

* Undo custom id docs (done in separate PR)

* Update docs, a bit

* fix create api doc

* Update docs/user/alerting/action-types/email.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/user/alerting/alerting-getting-started.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Indent warning

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: Mike Côté <mikecote@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaps gchaps gchaps approved these changes

@ymao1 ymao1 ymao1 approved these changes

@gmmorris gmmorris gmmorris approved these changes

Assignees

@mikecote mikecote

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.11.0 v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Catch-up release documentation - @mikecote
6 participants
@mikecote @elasticmachine @kibanamachine @gmmorris @ymao1 @gchaps