-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch-up release documentation #92411
Conversation
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -28,6 +28,8 @@ Creates an action. | |||
(Required, object) The secrets configuration for the action. Secrets configuration properties vary | |||
depending on the action type. For information about the secrets configuration properties, refer to <<action-types,Action and connector types>>. | |||
|
|||
WARNING: Remember these values. You must provide them each time you call the <<actions-and-connectors-api-update, update>> API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this note is specific to secrets, then it should be indented under secrets. Adding a "+" to the blank line above the warning should do the trick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct because it is specific to secrets
. Adding +
to the line above worked, thanks! Fixed in b24a4b1 ready for re-review.
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
…nto alerting/docs-catch-up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Initial commit * Undo custom id docs (done in separate PR) * Update docs, a bit * fix create api doc * Update docs/user/alerting/action-types/email.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/user/alerting/alerting-getting-started.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Indent warning Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
* Initial commit * Undo custom id docs (done in separate PR) * Update docs, a bit * fix create api doc * Update docs/user/alerting/action-types/email.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/user/alerting/alerting-getting-started.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Indent warning Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
* Initial commit * Undo custom id docs (done in separate PR) * Update docs, a bit * fix create api doc * Update docs/user/alerting/action-types/email.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/user/alerting/alerting-getting-started.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Indent warning Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
* Initial commit * Undo custom id docs (done in separate PR) * Update docs, a bit * fix create api doc * Update docs/user/alerting/action-types/email.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/user/alerting/alerting-getting-started.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Indent warning Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: Mike Côté <mikecote@users.noreply.github.com> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
* Initial commit * Undo custom id docs (done in separate PR) * Update docs, a bit * fix create api doc * Update docs/user/alerting/action-types/email.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/user/alerting/alerting-getting-started.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Indent warning Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: Mike Côté <mikecote@users.noreply.github.com> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
* Initial commit * Undo custom id docs (done in separate PR) * Update docs, a bit * fix create api doc * Update docs/user/alerting/action-types/email.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/user/alerting/alerting-getting-started.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Indent warning Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: Mike Côté <mikecote@users.noreply.github.com> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Resolves #90005.
Adds docs for the following PRs: