-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Correlations style polish in prep for release #92514
Merged
formgeist
merged 8 commits into
elastic:master
from
formgeist:apm-correlations-style-polish
Feb 24, 2021
Merged
[APM] Correlations style polish in prep for release #92514
formgeist
merged 8 commits into
elastic:master
from
formgeist:apm-correlations-style-polish
Feb 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
formgeist
added
Team:APM
All issues that need APM UI Team support
polish
v7.12.0
labels
Feb 23, 2021
Pinging @elastic/apm-ui (Team:apm) |
formgeist
added
release_note:skip
Skip the PR/issue when compiling release notes
v8.0.0
auto-backport
Deprecated - use backport:version if exact versions are needed
v7.13.0
labels
Feb 23, 2021
💚 Build SucceededMetrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @formgeist |
ogupte
approved these changes
Feb 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks a lot better!
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 24, 2021
- Removed the icon from the "View correlations" button - Moved the tabs to the FlyoutHeader - Removed unneeded spacers in the content - Reduced the filtering by callout and button - Made the introduction text color `subdued` to make it less noisy - Reduced ImpactBar size and extended width so the bar itself is `100` - Changed the selected term visualization color to `euiColorVis2` because the `euiColorAccent` is not great for visualizations. - Changed the latency distribution visualization color to `euiColorVis1` to make it consistent with the Transactions visualization colors in the other charts.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 24, 2021
- Removed the icon from the "View correlations" button - Moved the tabs to the FlyoutHeader - Removed unneeded spacers in the content - Reduced the filtering by callout and button - Made the introduction text color `subdued` to make it less noisy - Reduced ImpactBar size and extended width so the bar itself is `100` - Changed the selected term visualization color to `euiColorVis2` because the `euiColorAccent` is not great for visualizations. - Changed the latency distribution visualization color to `euiColorVis1` to make it consistent with the Transactions visualization colors in the other charts.
kibanamachine
added a commit
that referenced
this pull request
Feb 24, 2021
- Removed the icon from the "View correlations" button - Moved the tabs to the FlyoutHeader - Removed unneeded spacers in the content - Reduced the filtering by callout and button - Made the introduction text color `subdued` to make it less noisy - Reduced ImpactBar size and extended width so the bar itself is `100` - Changed the selected term visualization color to `euiColorVis2` because the `euiColorAccent` is not great for visualizations. - Changed the latency distribution visualization color to `euiColorVis1` to make it consistent with the Transactions visualization colors in the other charts. Co-authored-by: Casper Hübertz <casper@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 24, 2021
- Removed the icon from the "View correlations" button - Moved the tabs to the FlyoutHeader - Removed unneeded spacers in the content - Reduced the filtering by callout and button - Made the introduction text color `subdued` to make it less noisy - Reduced ImpactBar size and extended width so the bar itself is `100` - Changed the selected term visualization color to `euiColorVis2` because the `euiColorAccent` is not great for visualizations. - Changed the latency distribution visualization color to `euiColorVis1` to make it consistent with the Transactions visualization colors in the other charts. Co-authored-by: Casper Hübertz <casper@elastic.co>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 25, 2021
…bana into task-manager/docs-monitoring * 'task-manager/docs-monitoring' of github.com:gmmorris/kibana: (120 commits) Bump the CI Node.js version from 14.15.4 to 14.16.0 (elastic#92578) [Uptime] Search made easy (elastic#88581) [Lens] Stop requesting stats on Records field (elastic#92508) [APM] Correlations style polish in prep for release (elastic#92514) [Lens] Fix sorting undefined, null and NaN values (elastic#92575) Put environment back in uiFilters (elastic#92561) [Discover] Fix sorting by _score behavior (elastic#92132) Add metricbeat steps to jenkins_build_load_testing.sh (elastic#90290) [Usage Collection] Remove unused UI Metric APIs (elastic#91620) Fix timelion deprecation documentation links (elastic#92576) [TSVB] Enable `dual mode`, support index patterns and strings (elastic#92395) Fix text align in Safari (elastic#92374) [Actions][Doc] Clean up Actions README (elastic#91789) chore(NA): add missing files to exclude when building bazel prod packages (elastic#92506) [Security Solution][Endpoint][Admin] Match Policy Details in Security Solution with Fleet (elastic#92047) Revert "[build] Add task skips intended for partial builds (elastic#92076)" [Enterprise Search] Change icon for error in EuiCallouts (elastic#92527) [Alerts][Docs] Alert types doc update. Added refs to applications specific alerts groups. (elastic#91787) [Security Solution][Exceptions] - Update exceptions modal to use existing lists plugin useApi hook (elastic#92348) [DOCS] Updates refresh text in index pattern doc (elastic#92469) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
polish
release_note:skip
Skip the PR/issue when compiling release notes
Team:APM
All issues that need APM UI Team support
v7.12.0
v7.13.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some clean-up and polish styles for the new Correlations feature that has come up in testing.
subdued
to make it less noisy100
euiColorVis2
because theeuiColorAccent
is not great for visualizations.euiColorVis1
to make it consistent with the Transactions visualization colors in the other charts.