Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade lodash to 4.17.21 #92666

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Upgrade lodash to 4.17.21 #92666

merged 1 commit into from
Feb 24, 2021

Conversation

legrego
Copy link
Member

@legrego legrego commented Feb 24, 2021

Summary

Bumps lodash from 4.17.20 to 4.17.21

@legrego legrego force-pushed the chore/lodash-4.17.21 branch from 93072fa to 750f561 Compare February 24, 2021 17:39
@legrego legrego requested a review from a team February 24, 2021 19:35
@legrego legrego marked this pull request as ready for review February 24, 2021 19:35
@legrego legrego added release_note:skip Skip the PR/issue when compiling release notes v7.11.2 v7.12.0 v8.0.0 labels Feb 24, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1751 1753 +2
dashboard 196 198 +2
kibanaReact 334 336 +2
ml 1737 1739 +2
securitySolution 2202 2204 +2
total +10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.3MB 5.3MB +460.0B
kibanaReact 342.9KB 343.4KB +470.0B
ml 6.4MB 6.4MB +458.0B
securitySolution 7.7MB 7.7MB +462.0B
total +1.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 309.9KB 310.4KB +458.0B
Unknown metric groups

@kbn/ui-shared-deps asset size

id before after diff
kbn-ui-shared-deps.@elastic.js 2.5MB 2.5MB +2.0B
kbn-ui-shared-deps.js 7.4MB 7.4MB +602.0B
total +604.0B

History

  • 💔 Build #109137 failed 93072fa8934448bb2a731a8e56937293afdfb3d8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jportner
jportner reviewed Feb 24, 2021
View reviewed changes
package.json
@@ -390,7 +390,6 @@
"@storybook/addon-essentials": "^6.0.26",
"@storybook/addon-knobs": "^6.0.26",
"@storybook/addon-storyshots": "^6.0.26",
"@storybook/addons": "^6.0.16",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this removed on purpose?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I meant to leave a comment. This is a duplicate entry of https://github.com/elastic/kibana/pull/92666/files/750f561bf12c22f12b3864717900d42842641095#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R386

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I should have scrolled up 😄

jportner
jportner approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@legrego legrego added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 24, 2021
@legrego legrego merged commit 2950852 into elastic:master Feb 24, 2021
@legrego legrego deleted the chore/lodash-4.17.21 branch February 24, 2021 19:45
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 24, 2021
@legrego @kibanamachine
Upgrade lodash to 4.17.21 (elastic#92666)
0f9b0e6
@kibanamachine kibanamachine mentioned this pull request Feb 24, 2021
Merged
@kibanamachine
Copy link
Contributor

💔 Backport failed

❌ 7.11: Commit could not be cherrypicked due to conflicts
✅ 7.12 / #92704

Successful backport PRs will be merged automatically after passing CI.

To backport manually, check out the target branch and run:
node scripts/backport --pr 92666

legrego added a commit to legrego/kibana that referenced this pull request Feb 24, 2021
@legrego
Upgrade lodash to 4.17.21 (elastic#92666)
dd10f09 
# Conflicts:
#	yarn.lock
@legrego legrego mentioned this pull request Feb 24, 2021
Merged
@legrego
Copy link
Member Author

legrego commented Feb 24, 2021

Manual backport for 7.11: #92707

legrego added a commit that referenced this pull request Feb 24, 2021
@legrego
Upgrade lodash to 4.17.21 (#92666) (#92707)
1e0588b 
# Conflicts:
#	yarn.lock
kibanamachine added a commit that referenced this pull request Feb 25, 2021
@kibanamachine @legrego
[7.12] Upgrade lodash to 4.17.21 (#92666) (#92704)
b417d41 
* Upgrade lodash to 4.17.21 (#92666)

* adjust lockfile

* Fix storybook

Co-authored-by: Larry Gregory <larry.gregory@elastic.co>
@legrego legrego mentioned this pull request Feb 25, 2021
Merged
legrego added a commit to legrego/kibana that referenced this pull request Feb 25, 2021
@legrego
Upgrade lodash to 4.17.21 (elastic#92666)
2f95d8a
legrego added a commit that referenced this pull request Feb 25, 2021
@legrego
Upgrade lodash to 4.17.21 (#92666) (#92824)
e98eba2
@lukeelmers lukeelmers mentioned this pull request May 26, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jportner jportner jportner approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.11.2 v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legrego @kibanamachine @jportner