Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] Round up the end timestamp in the log stream embeddable #92833

Conversation

weltenwort
Copy link
Member

Summary

This fixes the interpretation of the end timestamp in the log stream embeddable such that it rounds it up. Without this a date range of now/d to now/d would be resolved to a zero-duration time range even though the date picker semantics are "Today".

@weltenwort weltenwort added bug Fixes for quality problems that affect the customer experience v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Feb 25, 2021
@weltenwort weltenwort added this to the Logs UI 7.12 milestone Feb 25, 2021
@weltenwort weltenwort self-assigned this Feb 25, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 165.3KB 165.3KB +5.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @weltenwort

@weltenwort weltenwort marked this pull request as ready for review February 25, 2021 18:20
@weltenwort weltenwort requested a review from a team as a code owner February 25, 2021 18:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@weltenwort weltenwort enabled auto-merge (squash) February 25, 2021 18:38
Copy link
Contributor

@afgomez afgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@weltenwort weltenwort merged commit c116477 into elastic:master Mar 1, 2021
@afgomez
Copy link
Contributor

afgomez commented Mar 1, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

ignoring request to update branch, pull request is closed

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 1, 2021
…astic#92833)

This fixes the interpretation of the end timestamp in the log stream embeddable such that it rounds it up. Without this a date range of `now/d` to `now/d` would be resolved to a zero-duration time range even though the date picker semantics are "Today".
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 1, 2021
…astic#92833)

This fixes the interpretation of the end timestamp in the log stream embeddable such that it rounds it up. Without this a date range of `now/d` to `now/d` would be resolved to a zero-duration time range even though the date picker semantics are "Today".
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.12 / #92996
7.x / #92997

Successful backport PRs will be merged automatically after passing CI.

gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 1, 2021
* master:
  [Logs UI] Round up the end timestamp in the log stream embeddable (elastic#92833)
  skip flaky suite (elastic#91939)
  skip flaky suite (elastic#89072)
  [APM] Include services with only metric documents (elastic#92378)
kibanamachine added a commit that referenced this pull request Mar 1, 2021
…2833) (#92996)

This fixes the interpretation of the end timestamp in the log stream embeddable such that it rounds it up. Without this a date range of `now/d` to `now/d` would be resolved to a zero-duration time range even though the date picker semantics are "Today".

Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Mar 1, 2021
…2833) (#92997)

This fixes the interpretation of the end timestamp in the log stream embeddable such that it rounds it up. Without this a date range of `now/d` to `now/d` would be resolved to a zero-duration time range even though the date picker semantics are "Today".

Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants