Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting][Docs] Alert type selection screenshot #92970

Merged
merged 1 commit into from
Mar 2, 2021
Merged

[Alerting][Docs] Alert type selection screenshot #92970

merged 1 commit into from
Mar 2, 2021

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Feb 26, 2021 •
edited
Loading

Summary

Updating alert type selection screenshot so 7.11 docs doesn't show 7.12 alert types.

Screenshot before alert-flyout-alert-type-selection
Fixed screenshot alert-flyout-alert-type-selection

@ymao1 ymao1 added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.11.0 v7.12.0 v7.13.0 labels Feb 26, 2021
@ymao1 ymao1 self-assigned this Feb 26, 2021
@ymao1 ymao1 requested a review from a team as a code owner February 26, 2021 15:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

gmmorris
gmmorris approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@gmmorris gmmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikecote mikecote self-requested a review March 2, 2021 19:34
mikecote
mikecote approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ymao1 ymao1 added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 2, 2021
@ymao1 ymao1 merged commit 319ad55 into elastic:master Mar 2, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 2, 2021
@ymao1 @kibanamachine
Different screenshot (elastic#92970)
71bd901
@kibanamachine kibanamachine mentioned this pull request Mar 2, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 2, 2021
@ymao1 @kibanamachine
Different screenshot (elastic#92970)
cb8b38a
@kibanamachine kibanamachine mentioned this pull request Mar 2, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 2, 2021
@ymao1 @kibanamachine
Different screenshot (elastic#92970)
3131b5a
@kibanamachine kibanamachine mentioned this pull request Mar 2, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.11 / #93308
✅ 7.12 / #93309
✅ 7.x / #93310

Successful backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 2, 2021
@kibanamachine @ymao1
Different screenshot (#92970) (#93309)
26fa8d4 
Co-authored-by: ymao1 <ying.mao@elastic.co>
kibanamachine added a commit that referenced this pull request Mar 2, 2021
@kibanamachine @ymao1
Different screenshot (#92970) (#93308)
aae6b9c 
Co-authored-by: ymao1 <ying.mao@elastic.co>
kibanamachine added a commit that referenced this pull request Mar 2, 2021
@kibanamachine @ymao1
Different screenshot (#92970) (#93310)
c0798e7 
Co-authored-by: ymao1 <ying.mao@elastic.co>
@ymao1 ymao1 deleted the alerting/doc-image branch March 25, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecote mikecote mikecote approved these changes

@gmmorris gmmorris gmmorris approved these changes

Assignees

@ymao1 ymao1

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.11.0 v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ymao1 @elasticmachine @kibanamachine @gmmorris @mikecote