[SecuritySolution][Case] Disable cases on detections in read-only mode #93010

cnasikas · 2021-03-01T11:19:26Z

Summary

When in a read-only mode a user can attach alerts to cases. This results in error toasters. This PR fixes this issue and prevents the user to attach alerts to cases. It also improves the tooltip message when the event is not supported.

Read-only mode:

Event not supported:

Fixes: #90718

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2021-03-01T11:19:28Z

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

elasticmachine · 2021-03-01T11:19:28Z

Pinging @elastic/security-solution (Team: SecuritySolution)

FrankHassanabad · 2021-03-01T15:41:10Z

...ugins/security_solution/public/cases/components/timeline_actions/add_to_case_action.test.tsx

+    );
+
+    wrapper.find(`[data-test-subj="attach-alert-to-case-button"]`).first().simulate('click');
+    wrapper.find(`[data-test-subj="add-new-case-item"]`).first().simulate('click');


nit: You don't need to interpolate here, you can just use '[data-test-subj="add-new-case-item"]'

FrankHassanabad

Looks great. Thanks for the work on this.

FrankHassanabad · 2021-03-01T19:11:54Z

x-pack/plugins/security_solution/cypress/integration/detection_alerts/attach_to_case.spec.ts

+  it('should not allow a read only user to attach alerts to cases', () => {
+    cy.get(ATTACH_ALERT_TO_CASE_BUTTON).first().should('be.disabled');
+  });
+});


This looks fine so far. The suggestion with permissions for e2e tests we have been making to each other is that we have 1 test which shows it being disabled for one role and then a second test which shows it being enabled for 1 more role.

This way if someone breaks the code so that it is disabled for all roles we can catch it.

kibanamachine · 2021-03-01T22:38:46Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 82d3eae
Storybooks Preview
Flaky suites:
- xpack-securitySolutionCypressChrome

Test Failures

Kibana Pipeline / general / "before all" hook for "should contain the right query".Timeline query tab Query tab "before all" hook for "should contain the right query"

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

AssertionError: Timed out retrying after 60000ms: Expected to find element: `[data-test-subj="title-7a523510-7ad6-11eb-a3c0-e9f982f35539"]`, but never found it.

Because this error occurred during a `before all` hook we are skipping the remaining tests in the current suite: `Timeline query tab`

Although you have test retries enabled, we do not retry tests when `before all` or `after all` hooks fail
    at Object.openTimelineById (http://localhost:6121/__cypress/tests?p=cypress/integration/timelines/query_tab.spec.ts:16058:15)
    at Context.eval (http://localhost:6121/__cypress/tests?p=cypress/integration/timelines/query_tab.spec.ts:15045:28)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	7.8MB	7.8MB	+1.2KB

History

💚 Build #110021 succeeded 063cdcd597608b7c22973cde584eefae3a8819f2
💚 Build #109846 succeeded fbb383e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

elastic#93010) * Disable cases on detetions on read-only mode * Add cypress tests

kibanamachine · 2021-03-01T22:41:26Z

💚 Backport successful

✅ 7.12 / #93144
✅ 7.x / #93145

Successful backport PRs will be merged automatically after passing CI.

#93010) (#93144) * Disable cases on detetions on read-only mode * Add cypress tests Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>

#93010) (#93145) * Disable cases on detetions on read-only mode * Add cypress tests Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>

* master: (42 commits) [Lens] Introduces new chart switcher (elastic#91844) [Lens] fix selection when dragging (elastic#93034) Converts usage collection README to .mdx (elastic#92982) Fix expanding document when using saved search data grid (elastic#92999) [SECURITY SOLUTIONS] Bug case connector (elastic#93104) [Security Solution] [Timeline] Bugfix to include unmapped fields in the timeline event details JSON (elastic#92025) [Alerting][Docs] Changed alerting documentation to point to a single source of explaining the configurations. (elastic#92942) [APM] Fix hidden search bar in error pages while loading (elastic#84476) (elastic#93139) [DOCS] Fixes links for machine learning alerts (elastic#92744) [Security Solution][Detections] -Fixes rule edit flow bug with max_signals (elastic#92748) [SecuritySolution][Case] Disable cases on detections in read-only mode (elastic#93010) [Security Solution][Case][Bug] Prevent closing collection when pushing (elastic#93095) [Security Solution][Detections][7.12] Critical Threshold Rule Fixes (elastic#92667) Bump ems landing page to 7.12 (elastic#93065) [App Search] Implement various Relevance Tuning states and form actions (elastic#92644) [actions] for simplistic email servers, set rejectUnauthorized to false (elastic#91760) [Security Solution][Case] Migrate category & subcategory fields of ServiceNow ITSM connector (elastic#93092) Hide instances latency distribution chart (elastic#92869) [Maps] fix MapboxDraw import from pointing to dist just pointing to folder (elastic#93087) [Maps] fix results trimmed tooltip message doubles feature count for line and polygon features (elastic#92932) ...

… playwright-ftr-e2e * 'playwright-ftr-e2e' of github.com:shahzad31/kibana: (38 commits) [chore] Enable core's eslint rule: `@ts-expect-error` (elastic#93086) [Lens] Introduces new chart switcher (elastic#91844) [Lens] fix selection when dragging (elastic#93034) Converts usage collection README to .mdx (elastic#92982) Fix expanding document when using saved search data grid (elastic#92999) [SECURITY SOLUTIONS] Bug case connector (elastic#93104) [Security Solution] [Timeline] Bugfix to include unmapped fields in the timeline event details JSON (elastic#92025) [Alerting][Docs] Changed alerting documentation to point to a single source of explaining the configurations. (elastic#92942) [APM] Fix hidden search bar in error pages while loading (elastic#84476) (elastic#93139) [DOCS] Fixes links for machine learning alerts (elastic#92744) [Security Solution][Detections] -Fixes rule edit flow bug with max_signals (elastic#92748) [SecuritySolution][Case] Disable cases on detections in read-only mode (elastic#93010) [Security Solution][Case][Bug] Prevent closing collection when pushing (elastic#93095) [Security Solution][Detections][7.12] Critical Threshold Rule Fixes (elastic#92667) Bump ems landing page to 7.12 (elastic#93065) [App Search] Implement various Relevance Tuning states and form actions (elastic#92644) [actions] for simplistic email servers, set rejectUnauthorized to false (elastic#91760) [Security Solution][Case] Migrate category & subcategory fields of ServiceNow ITSM connector (elastic#93092) Hide instances latency distribution chart (elastic#92869) [Maps] fix MapboxDraw import from pointing to dist just pointing to folder (elastic#93087) ...

… ilm/rollup-v2-action * 'ilm/rollup-v2-action' of github.com:elastic/kibana: (30 commits) Fix expanding document when using saved search data grid (#92999) [SECURITY SOLUTIONS] Bug case connector (#93104) [Security Solution] [Timeline] Bugfix to include unmapped fields in the timeline event details JSON (#92025) [Alerting][Docs] Changed alerting documentation to point to a single source of explaining the configurations. (#92942) [APM] Fix hidden search bar in error pages while loading (#84476) (#93139) [DOCS] Fixes links for machine learning alerts (#92744) [Security Solution][Detections] -Fixes rule edit flow bug with max_signals (#92748) [SecuritySolution][Case] Disable cases on detections in read-only mode (#93010) [Security Solution][Case][Bug] Prevent closing collection when pushing (#93095) [Security Solution][Detections][7.12] Critical Threshold Rule Fixes (#92667) Bump ems landing page to 7.12 (#93065) [App Search] Implement various Relevance Tuning states and form actions (#92644) [actions] for simplistic email servers, set rejectUnauthorized to false (#91760) [Security Solution][Case] Migrate category & subcategory fields of ServiceNow ITSM connector (#93092) Hide instances latency distribution chart (#92869) [Maps] fix MapboxDraw import from pointing to dist just pointing to folder (#93087) [Maps] fix results trimmed tooltip message doubles feature count for line and polygon features (#92932) [Security Solution][Detecttions] Indicator enrichment tweaks (#92989) [Maps] fix fit to data on heatmap not working (#92697) [Security Solution][Endpoint][Admin] Fixes policy sticky footer save test (#92919) ...

Disable cases on detetions on read-only mode

fbb383e

cnasikas added bug Fixes for quality problems that affect the customer experience v8.0.0 v7.12.0 Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.13.0 labels Mar 1, 2021

cnasikas requested a review from a team as a code owner March 1, 2021 11:19

cnasikas self-assigned this Mar 1, 2021

cnasikas added the release_note:skip Skip the PR/issue when compiling release notes label Mar 1, 2021

cnasikas requested a review from a team March 1, 2021 11:32

FrankHassanabad reviewed Mar 1, 2021

View reviewed changes

FrankHassanabad approved these changes Mar 1, 2021

View reviewed changes

FrankHassanabad reviewed Mar 1, 2021

View reviewed changes

Add cypress tests

82d3eae

cnasikas force-pushed the fix_90718 branch from 063cdcd to 82d3eae Compare March 1, 2021 20:11

cnasikas enabled auto-merge (squash) March 1, 2021 20:12

cnasikas added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 1, 2021

cnasikas merged commit aa62a13 into elastic:master Mar 1, 2021

cnasikas deleted the fix_90718 branch March 1, 2021 22:38

kibanamachine mentioned this pull request Mar 1, 2021

[7.12] [SecuritySolution][Case] Disable cases on detections in read-only mode (#93010) #93144

Merged

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 1, 2021

[SecuritySolution][Case] Disable cases on detections in read-only mode (

19613d4

elastic#93010) * Disable cases on detetions on read-only mode * Add cypress tests

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 1, 2021

[SecuritySolution][Case] Disable cases on detections in read-only mode (

c063a57

elastic#93010) * Disable cases on detetions on read-only mode * Add cypress tests

kibanamachine mentioned this pull request Mar 1, 2021

[7.x] [SecuritySolution][Case] Disable cases on detections in read-only mode (#93010) #93145

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SecuritySolution][Case] Disable cases on detections in read-only mode #93010

[SecuritySolution][Case] Disable cases on detections in read-only mode #93010

cnasikas commented Mar 1, 2021 •

edited

Loading

elasticmachine commented Mar 1, 2021

elasticmachine commented Mar 1, 2021

FrankHassanabad Mar 1, 2021

FrankHassanabad left a comment

FrankHassanabad Mar 1, 2021

kibanamachine commented Mar 1, 2021

Stack Trace

kibanamachine commented Mar 1, 2021

[SecuritySolution][Case] Disable cases on detections in read-only mode #93010

[SecuritySolution][Case] Disable cases on detections in read-only mode #93010

Conversation

cnasikas commented Mar 1, 2021 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Mar 1, 2021

elasticmachine commented Mar 1, 2021

FrankHassanabad Mar 1, 2021

Choose a reason for hiding this comment

FrankHassanabad left a comment

Choose a reason for hiding this comment

FrankHassanabad Mar 1, 2021

Choose a reason for hiding this comment

kibanamachine commented Mar 1, 2021

💛 Build succeeded, but was flaky

Test Failures

Stack Trace

Metrics [docs]

Async chunks

History

kibanamachine commented Mar 1, 2021

💚 Backport successful

cnasikas commented Mar 1, 2021 •

edited

Loading