Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable APM storybook publishing #93353

Merged
merged 4 commits into from
Mar 8, 2021
Merged

Enable APM storybook publishing #93353

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eb689f4
Enable APM storybook publishing
smith Mar 3, 2021
a8bc6f6
Merge branch 'master' into nls/apm-sb
kibanamachine Mar 5, 2021
2bc2f9a
Merge branch 'master' into nls/apm-sb
kibanamachine Mar 8, 2021
5f40a7d
Merge branch 'master' into nls/apm-sb
kibanamachine Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/scripts/jenkins_storybook.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ node scripts/storybook --dll

cd "$KIBANA_DIR"

# yarn storybook --site apm # TODO re-enable after being fixed
yarn storybook --site apm
yarn storybook --site canvas
yarn storybook --site ci_composite
yarn storybook --site url_template_editor
Expand Down
23 changes: 14 additions & 9 deletions x-pack/plugins/apm/public/components/alerting/error_count_alert_trigger/index.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import React from 'react';
import { MemoryRouter } from 'react-router-dom';
import { ErrorCountAlertTrigger } from '.';
import { EuiThemeProvider } from '../../../../../../../src/plugins/kibana_react/common';
import { ApmPluginContextValue } from '../../../context/apm_plugin/apm_plugin_context';
import {
mockApmPluginContextValue,
Expand All @@ -19,15 +20,19 @@ export default {
component: ErrorCountAlertTrigger,
decorators: [
(Story: React.ComponentClass) => (
<MockApmPluginContextWrapper
value={(mockApmPluginContextValue as unknown) as ApmPluginContextValue}
>
<MemoryRouter>
<div style={{ width: 400 }}>
<Story />
</div>
</MemoryRouter>
</MockApmPluginContextWrapper>
<EuiThemeProvider>
<MockApmPluginContextWrapper
value={
(mockApmPluginContextValue as unknown) as ApmPluginContextValue
}
>
<MemoryRouter>
<div style={{ width: 400 }}>
<Story />
</div>
</MemoryRouter>
</MockApmPluginContextWrapper>
</EuiThemeProvider>
),
],
};
Expand Down
21 changes: 12 additions & 9 deletions x-pack/plugins/apm/public/components/shared/ApmHeader/apm_header.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { EuiTitle } from '@elastic/eui';
import React, { ComponentType } from 'react';
import { MemoryRouter } from 'react-router-dom';
import { HttpSetup } from '../../../../../../../src/core/public';
import { EuiThemeProvider } from '../../../../../../../src/plugins/kibana_react/common';
import { MockApmPluginContextWrapper } from '../../../context/apm_plugin/mock_apm_plugin_context';
import { MockUrlParamsContextProvider } from '../../../context/url_params_context/mock_url_params_context_provider';
import { createCallApmApi } from '../../../services/rest/createCallApmApi';
Expand All @@ -22,15 +23,17 @@ export default {
createCallApmApi(({} as unknown) as HttpSetup);

return (
<MockUrlParamsContextProvider
params={{ rangeFrom: 'now-15m', rangeTo: 'now' }}
>
<MockApmPluginContextWrapper>
<MemoryRouter>
<Story />
</MemoryRouter>
</MockApmPluginContextWrapper>
</MockUrlParamsContextProvider>
<EuiThemeProvider>
<MockUrlParamsContextProvider
params={{ rangeFrom: 'now-15m', rangeTo: 'now' }}
>
<MockApmPluginContextWrapper>
<MemoryRouter>
<Story />
</MemoryRouter>
</MockApmPluginContextWrapper>
</MockUrlParamsContextProvider>
</EuiThemeProvider>
);
},
],
Expand Down