Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev/build_ts_refs] support disabling the ts-refs build completely #93529

Merged
merged 1 commit into from
Mar 4, 2021
Merged

[dev/build_ts_refs] support disabling the ts-refs build completely #93529

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/dev/typescript/build_ts_refs_cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,13 @@ const isTypeFailure = (error: any) =>
export async function runBuildRefsCli() {
run(
async ({ log, flags }) => {
if (process.env.BUILD_TS_REFS_DISABLE === 'true' && !flags.force) {
log.info(
'Building ts refs is disabled because the BUILD_TS_REFS_DISABLE environment variable is set to "true". Pass `--force` to run the build anyway.'
);
return;
}

const outDirs = getOutputsDeep(REF_CONFIG_PATHS);

const cacheEnabled = process.env.BUILD_TS_REFS_CACHE_ENABLE !== 'false' && !!flags.cache;
Expand Down Expand Up @@ -82,11 +89,12 @@ export async function runBuildRefsCli() {
{
description: 'Build TypeScript projects',
flags: {
boolean: ['clean', 'cache', 'ignore-type-failures'],
boolean: ['clean', 'force', 'cache', 'ignore-type-failures'],
default: {
cache: true,
},
help: `
--force Run the build even if the BUILD_TS_REFS_DISABLE is set to "true"
--clean Delete outDirs for each ts project before building
--no-cache Disable fetching/extracting outDir caches based on the mergeBase with upstream
--ignore-type-failures If tsc reports type errors, ignore them and just log a small warning.
Expand Down