Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Reviews data frame analytics UI text (#93033) #93562

Merged
merged 1 commit into from
Mar 4, 2021
Merged

[7.x] Reviews data frame analytics UI text (#93033) #93562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ..._frame_analytics/pages/analytics_creation/components/advanced_step/advanced_step_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ export const AdvancedStepForm: FC<CreateAnalyticsStepProps> = ({
})}
helpText={i18n.translate('xpack.ml.dataframe.analytics.create.maxNumThreadsHelpText', {
defaultMessage:
'The maximum number of threads to be used by the analysis. The default value is 1',
'The maximum number of threads to be used by the analysis. The default value is 1.',
})}
isInvalid={maxNumThreads === 0}
error={
Expand Down
6 changes: 3 additions & 3 deletions ..._analytics/pages/analytics_creation/components/advanced_step/outlier_hyper_parameters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export const OutlierHyperParameters: FC<Props> = ({ actions, state, advancedPara
})}
helpText={i18n.translate('xpack.ml.dataframe.analytics.create.methodHelpText', {
defaultMessage:
'Sets the method that outlier detection uses. If not set, uses an ensemble of different methods and normalises and combines their individual outlier scores to obtain the overall outlier score. We recommend to use the ensemble method',
'Sets the method that outlier detection uses. If not set, uses an ensemble of different methods, normalizes and combines their individual outlier scores to obtain the overall outlier score. It is recommended to use the ensemble method.',
})}
isInvalid={advancedParamErrors[ANALYSIS_ADVANCED_FIELDS.METHOD] !== undefined}
error={advancedParamErrors[ANALYSIS_ADVANCED_FIELDS.METHOD]}
Expand All @@ -56,7 +56,7 @@ export const OutlierHyperParameters: FC<Props> = ({ actions, state, advancedPara
})}
helpText={i18n.translate('xpack.ml.dataframe.analytics.create.nNeighborsHelpText', {
defaultMessage:
'The value for how many nearest neighbors each method of outlier detection will use to calculate its outlier score. When not set, different values will be used for different ensemble members. Must be a positive integer',
'The value for how many nearest neighbors each method of outlier detection uses to calculate its outlier score. When not set, different values are used for different ensemble members. Must be a positive integer.',
})}
isInvalid={advancedParamErrors[ANALYSIS_ADVANCED_FIELDS.N_NEIGHBORS] !== undefined}
error={advancedParamErrors[ANALYSIS_ADVANCED_FIELDS.N_NEIGHBORS]}
Expand All @@ -66,7 +66,7 @@ export const OutlierHyperParameters: FC<Props> = ({ actions, state, advancedPara
'xpack.ml.dataframe.analytics.create.nNeighborsInputAriaLabel',
{
defaultMessage:
'The value for how many nearest neighbors each method of outlier detection will use to calculate its outlier score.',
'The value for how many nearest neighbors each method of outlier detection uses to calculate its outlier score.',
}
)}
data-test-subj="mlAnalyticsCreateJobWizardnNeighborsInput"
Expand Down
2 changes: 1 addition & 1 deletion ...lytics/pages/analytics_creation/components/configuration_step/configuration_step_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@ export const ConfigurationStepForm: FC<CreateAnalyticsStepProps> = ({
'xpack.ml.dataframe.analytics.create.scatterplotMatrixLabelHelpText',
{
defaultMessage:
'Visualizes the relationships between pairs of selected included fields',
'Visualizes the relationships between pairs of selected included fields.',
}
)}
fullWidth
Expand Down