[TSVB] Change the default mode from last value to entire timerange #93608

VladLasitsa · 2021-03-04T14:36:46Z

Summary

Sets default value for "Data timerange mode" as entire time range. Also adds telemetry for count TSVB visualizations which use last value mode.

Telemetry has the following structure:

Dev Docs

Uses entire time range as default value for "Data timerange mode" in TSVB (top N, markdown, gauge, metric, table).

…value' mode

VladLasitsa · 2021-03-05T07:18:09Z

@elasticmachine merge upstream

VladLasitsa · 2021-03-09T06:29:32Z

@elasticmachine merge upstream

VladLasitsa · 2021-03-10T16:33:24Z

@elasticmachine merge upstream

kibanamachine · 2021-03-10T16:33:26Z

merge conflict between base and head

src/plugins/vis_type_timeseries/server/usage_collector/get_usage_collector.ts

VladLasitsa · 2021-03-11T07:52:47Z

@elasticmachine merge upstream

kibanamachine · 2021-03-11T07:52:48Z

merge conflict between base and head

test/functional/page_objects/visual_builder_page.ts

alexwizp

These changes looks good to me. I have only one question about description. For me it looks like a breaking change cause all new visualizations will use a different mode. Maybe we should somehow to highlight that by adding Release Nodes / Dev Docs. @stratoula any ideas?

stratoula · 2021-03-11T10:50:54Z

I agree let's add a brief Dev Docs section to notify the users about this change.

afharo

Thank you for adding the descriptions! LGTM!

VladLasitsa · 2021-03-22T06:56:06Z

@elasticmachine merge upstream

stratoula · 2021-03-23T08:56:48Z

@elasticmachine merge upstream

stratoula · 2021-03-23T09:28:50Z

test/functional/apps/visualize/_tsvb_chart.ts

@@ -86,7 +89,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
        const labelString = await PageObjects.visualBuilder.getGaugeLabel();
        expect(labelString).to.be('Count');
        const gaugeCount = await PageObjects.visualBuilder.getGaugeCount();
-        expect(gaugeCount).to.be('156');
+        expect(gaugeCount).to.be('13,830');


Why this needs to change?

I think it because with that changes by default we use EntireTimeRange instead of LastValue. 13,830 was calculated for the whole timeperiod

Oh, I see. I am fine then. We could also set the mode to Last Value and not change the test but I have no strong objection.

stratoula

The usage collector works fine now. What doesn't is the following scenario:
I have an already existing timeseries TSVB viz. I choose to edit it, if I navigate to the metric Tab for example, I see that the mode is set to Last Value. It should default to entire timerange

Moreover I suggest to add a functional test to check if the entire timerange is selected for an new TSVB viz.

Finally, I see that we changed the value of a functional test. Why? I see above that you set the value to Last value, so this shouldn't change, right?

VladLasitsa · 2021-03-25T14:50:08Z

The usage collector works fine now. What doesn't is the following scenario:
I have an already existing timeseries TSVB viz. I choose to edit it, if I navigate to the metric Tab for example, I see that the mode is set to Last Value. It should default to entire timerange

Fixed it.

Moreover I suggest to add a functional test to check if the entire timerange is selected for an new TSVB viz.

Added functional test for it.

Finally, I see that we changed the value of a functional test. Why? I see above that you set the value to Last value, so this shouldn't change, right?

I have done this so that we cover both cases when we have 'Last value' and 'Entire time range'.

stratoula

Code LGTM, it works as expected now. Thank you @VladLasitsa, feel free to merge it when it is green

VladLasitsa · 2021-03-26T07:29:40Z

@elasticmachine merge upstream

alexwizp · 2021-03-26T13:47:30Z

@elasticmachine merge upstream

kibanamachine · 2021-03-29T14:01:25Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`visTypeTimeseries`	1.6MB	1.6MB	+484.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @VladLasitsa

stratoula · 2021-03-29T14:10:17Z

@elasticmachine run elasticsearch-ci/docs

…lastic#93608) * Make 'enter time range' value as default and add telemetry for 'last value' mode * Fix telemetry schema * Fix test * Add possibility count timeseries created from dashboard * Fix remark * Fix remark * Fix problem with time_range_mode * Fix tests * Fix tests * Fix tests for markdown and table * exclude TSVB which have type as timeseries * Add description for field in schema in telemetry * Fix telemetry schema * Fix some remarks * Added check for hits * fix CI * fix CI Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>

…93608) (#95662) * Make 'enter time range' value as default and add telemetry for 'last value' mode * Fix telemetry schema * Fix test * Add possibility count timeseries created from dashboard * Fix remark * Fix remark * Fix problem with time_range_mode * Fix tests * Fix tests * Fix tests for markdown and table * exclude TSVB which have type as timeseries * Add description for field in schema in telemetry * Fix telemetry schema * Fix some remarks * Added check for hits * fix CI * fix CI Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>

Make 'enter time range' value as default and add telemetry for 'last …

d280d71

…value' mode

VladLasitsa requested review from alexwizp and stratoula March 4, 2021 14:36

Fix telemetry schema

c40435c

kibanamachine and others added 2 commits March 5, 2021 02:18

Merge branch 'master' into 91506

e603ba8

Fix test

1d97f64

Merge branch 'master' into 91506

dd4ec9a

VladLasitsa self-assigned this Mar 9, 2021

VladLasitsa added Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.13.0 v8.0.0 labels Mar 9, 2021

Add possibility count timeseries created from dashboard

aa3e14e

alexwizp reviewed Mar 11, 2021

View reviewed changes

src/plugins/vis_type_timeseries/server/usage_collector/get_usage_collector.ts Outdated Show resolved Hide resolved

VladLasitsa added 2 commits March 11, 2021 10:56

Merge remote-tracking branch 'upstream/master' into 91506

67b09cd

Fix remark

022536d

alexwizp reviewed Mar 11, 2021

View reviewed changes

test/functional/page_objects/visual_builder_page.ts Outdated Show resolved Hide resolved

alexwizp approved these changes Mar 11, 2021

View reviewed changes

VladLasitsa added the release_note:enhancement label Mar 11, 2021

Fix remark

07d57eb

VladLasitsa marked this pull request as ready for review March 11, 2021 13:36

VladLasitsa requested review from a team as code owners March 11, 2021 13:36

VladLasitsa requested a review from a team March 11, 2021 13:36

Merge branch 'master' into 91506

22e5044

afharo approved these changes Mar 18, 2021

View reviewed changes

Merge branch 'master' into 91506

1dde0a7

Merge branch 'master' into 91506

c64d7ff

stratoula reviewed Mar 23, 2021

View reviewed changes

VladLasitsa added 2 commits March 25, 2021 16:37

Merge remote-tracking branch 'upstream/master' into 91506

08a0c7b

Fix some remarks

2726d4e

Added check for hits

b62b757

stratoula approved these changes Mar 26, 2021

View reviewed changes

kibanamachine and others added 2 commits March 26, 2021 03:29

Merge branch 'master' into 91506

e98f15f

fix CI

26b750b

kibanamachine and others added 4 commits March 26, 2021 09:47

Merge branch 'master' into 91506

1c24005

fix CI

a39e0ac

Merge remote-tracking branch 'upstream/master' into 91506

b0955c7

Merge remote-tracking branch 'origin/91506' into 91506

3852f53

VladLasitsa merged commit 0e40b94 into elastic:master Mar 29, 2021

VladLasitsa mentioned this pull request Mar 29, 2021

[7.x] [TSVB] Change the default mode from last value to entire timerange (#93608) #95662

Merged

alexwizp mentioned this pull request Apr 19, 2021

[TSVB] Fix validation for Data time range mode combo-box #97475

Merged

timroes added the Feature:TSVB TSVB (Time Series Visual Builder) label Apr 26, 2021

stratoula mentioned this pull request Oct 14, 2021

[TSVB] Chart with override index pattern and last_value are migrated with entire_time_range from 7.13+ #114984

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TSVB] Change the default mode from last value to entire timerange #93608

[TSVB] Change the default mode from last value to entire timerange #93608

VladLasitsa commented Mar 4, 2021 •

edited

Loading

VladLasitsa commented Mar 5, 2021

VladLasitsa commented Mar 9, 2021

VladLasitsa commented Mar 10, 2021

kibanamachine commented Mar 10, 2021

VladLasitsa commented Mar 11, 2021

kibanamachine commented Mar 11, 2021

alexwizp left a comment •

edited

Loading

stratoula commented Mar 11, 2021

afharo left a comment

VladLasitsa commented Mar 22, 2021

stratoula commented Mar 23, 2021

stratoula Mar 23, 2021

alexwizp Mar 23, 2021

stratoula Mar 23, 2021 •

edited

Loading

stratoula left a comment

VladLasitsa commented Mar 25, 2021

stratoula left a comment

VladLasitsa commented Mar 26, 2021

alexwizp commented Mar 26, 2021

kibanamachine commented Mar 29, 2021

stratoula commented Mar 29, 2021

[TSVB] Change the default mode from last value to entire timerange #93608

[TSVB] Change the default mode from last value to entire timerange #93608

Conversation

VladLasitsa commented Mar 4, 2021 • edited Loading

Summary

Dev Docs

VladLasitsa commented Mar 5, 2021

VladLasitsa commented Mar 9, 2021

VladLasitsa commented Mar 10, 2021

kibanamachine commented Mar 10, 2021

VladLasitsa commented Mar 11, 2021

kibanamachine commented Mar 11, 2021

alexwizp left a comment • edited Loading

Choose a reason for hiding this comment

stratoula commented Mar 11, 2021

afharo left a comment

Choose a reason for hiding this comment

VladLasitsa commented Mar 22, 2021

stratoula commented Mar 23, 2021

stratoula Mar 23, 2021

Choose a reason for hiding this comment

alexwizp Mar 23, 2021

Choose a reason for hiding this comment

stratoula Mar 23, 2021 • edited Loading

Choose a reason for hiding this comment

stratoula left a comment

Choose a reason for hiding this comment

VladLasitsa commented Mar 25, 2021

stratoula left a comment

Choose a reason for hiding this comment

VladLasitsa commented Mar 26, 2021

alexwizp commented Mar 26, 2021

kibanamachine commented Mar 29, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

History

stratoula commented Mar 29, 2021

VladLasitsa commented Mar 4, 2021 •

edited

Loading

alexwizp left a comment •

edited

Loading

stratoula Mar 23, 2021 •

edited

Loading