Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename googlecloud to gcp in Add Data UI #93725

Merged
merged 6 commits into from
Mar 12, 2021

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Mar 5, 2021

Summary

With renaming googlecloud to gcp in Metricbeat and Filebeat(elastic/beats#22214), we also need to update Kibana Add Data UI to use the new name.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

Screenshots

Metrics:
Screen Shot 2021-03-12 at 4 31 13 AM

Logs:
Screen Shot 2021-03-12 at 4 35 57 AM

@kaiyan-sheng kaiyan-sheng self-assigned this Mar 5, 2021
@kaiyan-sheng kaiyan-sheng added Team:Integrations Team Label for Observability Integrations team release_note:fix release_note:skip Skip the PR/issue when compiling release notes v7.12.1 and removed release_note:fix labels Mar 5, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kaiyan-sheng

@kaiyan-sheng kaiyan-sheng merged commit 2b372fa into elastic:master Mar 12, 2021
@kaiyan-sheng kaiyan-sheng deleted the fix_gcp branch March 12, 2021 02:21
sayden pushed a commit to sayden/kibana that referenced this pull request Mar 15, 2021
sayden added a commit that referenced this pull request Mar 15, 2021
Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
sayden added a commit that referenced this pull request Mar 15, 2021
Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Integrations Team Label for Observability Integrations team v7.12.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants