Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] [Cases] rename case dir/plugin/context/i18n to cases #94149

Merged
merged 8 commits into from
Mar 10, 2021
Merged

[Security Solution] [Cases] rename case dir/plugin/context/i18n to cases #94149

merged 8 commits into from
Mar 10, 2021

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Mar 9, 2021 •
edited by cnasikas
Loading

Summary

Rename case directory/plugin to cases, along with context.case => context.cases, and i18n updates from case to cases

Release note

Renames Kibana configuration (kibana.yml) from xpack.case.enabled to xpack.cases.enabled.

Checklist

Delete any items that are not applicable to this PR.

@stephmilovic stephmilovic added Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Cases Cases feature Theme: rac label obsolete labels Mar 9, 2021
@stephmilovic stephmilovic marked this pull request as ready for review March 9, 2021 20:07
@stephmilovic stephmilovic requested review from a team as code owners March 9, 2021 20:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@stephmilovic stephmilovic added release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0 labels Mar 9, 2021
spalger
spalger approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Operations code owner files LGTM

@crob611 crob611 removed the request for review from a team March 9, 2021 20:27
YulNaumenko
YulNaumenko approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alerting related changes LGTM

michaelolo24
michaelolo24 approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🙌🏾 LGTM!

@stephmilovic stephmilovic merged commit 2bb2329 into elastic:master Mar 10, 2021
@stephmilovic stephmilovic mentioned this pull request Mar 10, 2021
Merged
stephmilovic added a commit to stephmilovic/kibana that referenced this pull request Mar 10, 2021
@stephmilovic
[Security Solution] [Cases] rename case dir/plugin/context/i18n to ca…
d3df971 
…ses (elastic#94149)
stephmilovic added a commit that referenced this pull request Mar 10, 2021
@stephmilovic
[Security Solution] [Cases] rename case dir/plugin/context/i18n to ca…
0c1d562 
…ses (#94149) (#94318)
@cnasikas cnasikas added release_note:breaking and removed release_note:skip Skip the PR/issue when compiling release notes labels Mar 17, 2021
@cnasikas
Copy link
Member

@stephmilovic I marked the PR as breaking because xpack.case.enabled in kibana.yml has to change to xpack.cases.enabled (case -> cases).

@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 17, 2021 •
edited
Loading

⏳ Build in-progress, with failures

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mikecote
Copy link
Contributor

@cnasikas you can also deprecate the settings as we did here: https://github.com/elastic/kibana/blob/master/x-pack/plugins/alerting/server/index.ts#L41-L51. This automatically re-routes the configuration until you remove the code (say 8.0).

@cnasikas
Copy link
Member

@mikecote Thank you!

@stephmilovic stephmilovic mentioned this pull request Mar 17, 2021
Merged
@cnasikas
Copy link
Member

@mikecote If we do what you proposed do we still need to mark it as breaking change or it is sufficient to mention it on the docs?

@mikecote
Copy link
Contributor

@mikecote If we do what you proposed do we still need to mark it as breaking change or it is sufficient to mention it on the docs?

It would no longer be a breaking change since the configuration will still work for customers until you decide to remove it. There will be deprecation logs so maybe documenting that?

@cnasikas cnasikas added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:breaking labels Mar 17, 2021
@cnasikas
Copy link
Member

I removed the breaking changes label because of #94808.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@michaelolo24 michaelolo24 michaelolo24 approved these changes

@spalger spalger spalger approved these changes

@tylersmalley tylersmalley tylersmalley approved these changes

Assignees
No one assigned
Labels
Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team Theme: rac label obsolete v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@stephmilovic @elasticmachine @cnasikas @kibanamachine @mikecote @tylersmalley @spalger @michaelolo24 @YulNaumenko