Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Functional tests for Anomaly swim lane #94723

Merged
merged 26 commits into from
Mar 24, 2021
Merged

[ML] Functional tests for Anomaly swim lane #94723

merged 26 commits into from
Mar 24, 2021

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Mar 16, 2021 •
edited
Loading

Summary

Part of #93205

Adds functional tests for Anomaly swim lanes on the Anomaly Explorer page.

  • Single-cell selection on the Overall swim lane
  • Single-cell selection on the View By swim lane
  • Multiple cells selection with a brush action
  • Swim lane pagination tests

Checklist

@darnautov darnautov added :ml Feature:Anomaly Detection ML anomaly detection test_ui_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 16, 2021
@darnautov darnautov self-assigned this Mar 16, 2021
@darnautov darnautov mentioned this pull request Mar 16, 2021
Closed
15 tasks
@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

@darnautov darnautov marked this pull request as ready for review March 22, 2021 09:13
@darnautov darnautov requested a review from a team as a code owner March 22, 2021 09:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov darnautov requested a review from jgowdyelastic March 22, 2021 19:26
peteharverson
peteharverson approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Anomaly Explorer suite locally and LGTM

jgowdyelastic
jgowdyelastic approved these changes Mar 23, 2021
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

pheyos
pheyos reviewed Mar 23, 2021
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these tests! 🎉
Overall looking good, just left a few comments.

x-pack/test/functional/services/ml/navigation.ts Outdated Show resolved Hide resolved
x-pack/test/functional/services/ml/anomaly_explorer.ts Outdated Show resolved Hide resolved
x-pack/test/functional/apps/ml/anomaly_detection/anomaly_explorer.ts Show resolved Hide resolved
x-pack/test/functional/apps/ml/anomaly_detection/anomaly_explorer.ts Show resolved Hide resolved
x-pack/test/functional/apps/ml/anomaly_detection/anomaly_explorer.ts Outdated Show resolved Hide resolved
x-pack/test/functional/services/ml/swim_lane.ts Outdated Show resolved Hide resolved
x-pack/test/functional/services/ml/swim_lane.ts Outdated Show resolved Hide resolved
x-pack/test/functional/services/ml/swim_lane.ts Outdated Show resolved Hide resolved
x-pack/test/functional/services/ml/swim_lane.ts Outdated Show resolved Hide resolved
x-pack/test/functional/services/ml/swim_lane.ts Outdated Show resolved Hide resolved
@darnautov
Copy link
Contributor Author

hey @pheyos, I've addressed your comments 🚀

@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

pheyos
pheyos approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@darnautov darnautov enabled auto-merge (squash) March 24, 2021 12:51
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 6.0MB 6.0MB +595.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov merged commit edaa64f into elastic:master Mar 24, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 24, 2021
@darnautov @kibanamachine
[ML] Functional tests for Anomaly swim lane (elastic#94723)
f6b2b0d 
* [ML] update @elastic/charts

* [ML] swim lane service, axes tests

* [ML] check single cell selection and current URL

* [ML] clear selection

* [ML] assert anomaly explorer charts

* [ML] fix unit test

* [ML] assert anomalies table and top influencers list

* [ML] update apiDoc version

* [ML] exclude host from the URL assertion

* [ML] clicks view by swim lane

* [ML] fix method for cell selection

* [ML] brush action tests

* [ML] use debug state flag

* [ML] declare window interface

* [ML] pagination tests

* [ML] enable test

* [ML] scroll into view for swim lane actions

* [ML] rename URL assertion method

* [ML] fix assertion for charts count

* [ML] extend assertion

* [ML] refactor test subjects selection

* [ML] fix assertSelection

* [ML] reduce timeout for charts assertion
@kibanamachine kibanamachine mentioned this pull request Mar 24, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.x / #95313

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 24, 2021
@kibanamachine @darnautov
[ML] Functional tests for Anomaly swim lane (#94723) (#95313)
95e07fe 
* [ML] update @elastic/charts

* [ML] swim lane service, axes tests

* [ML] check single cell selection and current URL

* [ML] clear selection

* [ML] assert anomaly explorer charts

* [ML] fix unit test

* [ML] assert anomalies table and top influencers list

* [ML] update apiDoc version

* [ML] exclude host from the URL assertion

* [ML] clicks view by swim lane

* [ML] fix method for cell selection

* [ML] brush action tests

* [ML] use debug state flag

* [ML] declare window interface

* [ML] pagination tests

* [ML] enable test

* [ML] scroll into view for swim lane actions

* [ML] rename URL assertion method

* [ML] fix assertion for charts count

* [ML] extend assertion

* [ML] refactor test subjects selection

* [ML] fix assertSelection

* [ML] reduce timeout for charts assertion

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@peteharverson peteharverson peteharverson approved these changes

@pheyos pheyos pheyos approved these changes

@walterra walterra Awaiting requested review from walterra

Assignees

@darnautov darnautov

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@darnautov @elasticmachine @kibanamachine @pheyos @peteharverson @jgowdyelastic