[Cases] Fix _find API total bug #95235
Conversation
jonathan-buttner
added
v8.0.0
release_note:skip
| @@ -6,6 +6,8 @@ | |||
| */ | |||
|
|
|||
| import expect from '@kbn/expect'; | |||
| import supertestAsPromised from 'supertest-as-promised'; | |||
There was a problem hiding this comment.
These changes look worse than they are. I wrapped the original tests in a describe block so I could create a new describe for the pagination tests. These tests should be equivalent to the ones added here: #94971
| count_closed_cases: 0, | ||
| count_in_progress_cases: 0, | ||
| describe('basic find tests', () => { | ||
| afterEach(async () => { |
There was a problem hiding this comment.
Moved the deletion of the sub cases to only the basic tests so they don't delete the sub cases for the pagination describe block.
| caseID: caseInfo.id, | ||
| actionID, | ||
| describe('pagination', () => { | ||
| const numCases = 4; |
There was a problem hiding this comment.
Only doing 4 sub cases for the pagination because it takes a long time create the sub cases.
| .send(postCollectionReq) | ||
| .expect(200)); | ||
|
|
||
| await createSubCases(numCases, collection.id); |
There was a problem hiding this comment.
Can't use a Promise.all here because we run into saved object conflicts when the alerts get generated.
| supertest, | ||
| caseID: caseInfo.id, | ||
| actionID, | ||
| describe('pagination', () => { |
There was a problem hiding this comment.
I tested these locally but they're skipped anyway because the case connector feature is disabled.
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
* Cherry-picking 7.12 find total fix * Starting fix for total bug in master with new field * Adding feature flag for sub cases * Disabling case as a connector in security solution * Adding additional tests for pagination * Removing other api integration tests * Fixing up problems from merge * Fixing sub case tests and type errors * Renaming comment tag for case connector
* Cherry-picking 7.12 find total fix * Starting fix for total bug in master with new field * Adding feature flag for sub cases * Disabling case as a connector in security solution * Adding additional tests for pagination * Removing other api integration tests * Fixing up problems from merge * Fixing sub case tests and type errors * Renaming comment tag for case connector
Summary
This PR is waiting on this one: #95122 to be merged because they share some of the same files for restructuring the integration tests.This PR address the bug described here: #94929 where the
_findcases API does not return the correct value for thetotalfield. This makes the UI think there are no additional cases and therefore breaks the pagination functionality.The backend was incorrectly setting the
totalfield to be the number of cases that were returned by the saved objects find call. Instead it should be setting thetotalfield to the returnedtotalattribute in the saved objects client response.This solution will work until the sub cases feature is enabled by default. Once that occurs it will be possible to have empty case collections which in most cases should probably be ignored in the case list view. If we end up going that route we'll need to filter out the empty collections and adjust the
totalresponse accordingly.A possible solution would be to add a new field to the case saved object that indicates if a collection is empty or not. We'd need to check and set the field any time a sub case is added to the collection or deleted from a collection which could run into race conditions.