unskipping functional tests to check their flakiness #95349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashmivkulkarni
added
test_ui_functional
test_xpack_functional
v8.0.0
release_note:skip
pheyos
requested changes
Mar 25, 2021
There was a problem hiding this comment.
Hi. Good to see that skipped tests are checked for flakiness! My two items:
- Left a comment on the ML test, see below.
- A general note: many
.skip's are accompanied by a code comment pointing to an issue. If the.skipis removed, I think the corresponding issue should be closed (linking to this fix PR) and the comment should be removed.
Comment on lines
17
to
+18
| // FLAKY: https://github.com/elastic/kibana/issues/93188 | ||
| describe.skip('total feature importance panel and decision path popover', function () { | ||
| describe('total feature importance panel and decision path popover', function () { |
There was a problem hiding this comment.
As you can see from the issues linked in the comment, this has just recently been skipped and we're investigating how to stabilize it. It's failing rather rarely but it's definitely flaky, so chances are that it would pass your PR checks but fail later after re-activation. Please don't remove this skip for now.
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
This was referenced Apr 1, 2021
|
@elasticmachine merge upstream |
|
I'm going to mark this as draft until the PR is ready to review |
⏳ Build in-progress, with failures
Failed CI StepsHistory
To update your PR or re-run it, just comment with: |
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/visualize/_add_to_dashboard·ts.visualize app Add to Dashboard adding a new metric to an existing dashboard by valueStandard OutStack TraceKibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/dashboard/url_field_formatter·ts.dashboard app using current data Changing field formatter to Url "before all" hook for "applied on dashboard"Standard OutStack TraceKibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/dashboard/url_field_formatter·ts.dashboard app using current data Changing field formatter to Url "before all" hook for "applied on dashboard"Standard OutStack Traceand 10 more failures, only showing the first 3. Metrics [docs]
History
To update your PR or re-run it, just comment with: |
|
similar effort: #110310 |
|
closing this PR in lieu of: #110310 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
....from Kibana and x-pack dir
Notes: Used a
sedcommand to find and replace.skiptests.grep -r ".skip(" test/functional/apps/* -B 1 — mastercd into test/functional/apps/
for i in `find ./ -type f`; do sed -i.bu "s|\.skip(|(|g" $i; done--- bu - backup , s - substitute , .skip( - replace with just (|
Repeat for x-pack test/functional/apps
to check:
git diff --cached