Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ingest pipeline links to documentation link service #95837

Merged
merged 3 commits into from
Apr 1, 2021
Merged

Adds ingest pipeline links to documentation link service #95837

merged 3 commits into from
Apr 1, 2021

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Mar 30, 2021

Summary

Related to #88107
This PR adds keywords to the doc link service for pages that are linked in the x-pack/plugins/ingest_pipelines/public/application/components/pipeline_editor files, such as https://github.com/elastic/kibana/blob/master/x-pack/plugins/ingest_pipelines/public/application/components/pipeline_editor/components/shared/map_processor_type_to_form.tsx

Those hard-coded links will be updated to use the appropriate keyword from the doc link service in a subsequent PR.

@lcawl lcawl added v7.13.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Mar 30, 2021
@lcawl lcawl marked this pull request as ready for review March 30, 2021 21:52
@lcawl lcawl requested a review from a team as a code owner March 30, 2021 21:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

afharo
afharo approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Great effort! LGTM!

@lcawl
Copy link
Contributor Author

lcawl commented Apr 1, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 373.0KB 375.2KB +2.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit 32f2409 into elastic:master Apr 1, 2021
@lcawl lcawl deleted the ingest-links branch April 1, 2021 21:21
lcawl added a commit to lcawl/kibana that referenced this pull request Apr 1, 2021
@lcawl
Adds ingest pipeline links to documentation link service (elastic#95837)
b8ecb05
@lcawl lcawl mentioned this pull request Apr 1, 2021
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 5, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

4 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 12, 2021
lcawl added a commit that referenced this pull request Apr 12, 2021
@lcawl
Adds ingest pipeline links to documentation link service (#95837) (#9…
4b4b192 
…6103)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lcawl @elasticmachine @kibanamachine @afharo