[Fleet] Can't select managed agent. Bulk upgrade agent UI changes #96087

jfsiii · 2021-04-01T19:30:56Z

Summary

This PR implements several items from point 8 in https://github.com/elastic/observability-design/issues/32

The changes to modal titles and success/error behavior are only for bulk upgrade in this PR. Once we confirm the pattern, I'll apply it to unenroll and reassign in a follow up PR.

Disable the checkbox for agents enrolled in a hosted agent policy. We don't need to provide a tooltip description since the Agent policy "lock" icon appears in the table row.
If a user selects the top-left checkbox to select all agents on the page, and then clicks "select everything on all pages", we don't need to provide a count for total number of agents selected. The bulk actions button can say "all agents selected" (as discussed, calculating the total number of agents is problematic and can be tough on performance). Choosing a bulk action should filter out / not include any agents that are enrolled in a hosted agent policy.
Related to calculating total number of agents, we previously showed a count in the action modal's title. In the case where users have selected everything on all pages, the title can just say "all selected agents" -> i.e. "upgrade all selected agents"
If the result of a bulk action has mixed results, as in some percentage of agents are successful but others fail, show a warning toast that indicates how many succeeded and how many failed. See screenshot below.
Change the "experimental" badge for the upgrade agent action modal to be an icon only badge. You can use the beaker icon. The badge should use the same tooltip description that we use today indicating that this action is experimental.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

Per feature details & screenshots

Disable the checkbox for agents enrolled in a hosted agent policy.

We don't need to provide a tooltip description since the Agent policy "lock" icon appears in the table row.

I left the description in until we implement the "lock" icon.

If a user selects the top-left checkbox to select all agents on the page, and then clicks "select everything on all pages", ... the bulk actions button can say "all agents selected"

Choosing a bulk action should filter out / not include any agents that are enrolled in a hosted agent policy.

There are 7 rows, but only 6 were attempted because 1 is managed

When users have selected everything on all pages, the title can just say "all selected agents" -> i.e. "upgrade all selected agents"

the text inside the modal was also updated per the screenshots

Single agent case

Multiple items but not "all"

If the result of a bulk action has mixed results, as in some percentage of agents are successful but others fail, show a warning toast that indicates how many succeeded and how many failed

Mixed success & failure: show warning

All succeed. Variants for multiple vs all selected

All fail. Variants for multiple vs all selected

Change the "experimental" badge for the upgrade agent action modal to be an icon only badge. You can use the `beaker` icon. The badge should use the same tooltip description that we use today indicating that this action is experimental.

...ins/fleet/public/applications/fleet/sections/agents/components/agent_upgrade_modal/index.tsx

jfsiii · 2021-04-02T00:47:15Z

@elasticmachine merge upstream

elasticmachine · 2021-04-02T16:18:42Z

Pinging @elastic/fleet (Team:Fleet)

jfsiii · 2021-04-05T11:50:07Z

@elasticmachine merge upstream

kibanamachine · 2021-04-05T11:50:08Z

user doesn't have permission to update head repository

jfsiii · 2021-04-05T18:01:19Z

@elasticmachine merge upstream

kibanamachine · 2021-04-05T18:01:20Z

user doesn't have permission to update head repository

jfsiii · 2021-04-05T18:03:58Z

@elasticmachine merge upstream

kibanamachine · 2021-04-05T18:03:59Z

user doesn't have permission to update head repository

jfsiii · 2021-04-05T18:07:02Z

@elasticmachine merge upstream

hbharding

LGTM thanks @jfsiii

kibanamachine · 2021-04-05T20:05:28Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	707.7KB	709.5KB	+1.8KB

History

💚 Build #117065 succeeded d3280ea
💛 Build #116981 was flaky 6925b0f
💔 Build #116913 failed 5711a80

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jfsiii

nchaulet · 2021-04-06T13:29:03Z

.../fleet/public/applications/fleet/sections/agents/agent_list_page/components/bulk_actions.tsx

@@ -148,12 +148,21 @@ export const AgentBulkActions: React.FunctionComponent<{
    },
  ];

+  const showSelectEverything =
+    selectionMode === 'manual' &&
+    selectedAgents.length === selectableAgents &&


selectableAgents is only on the current page right? so you can select everything but have non selectable agents on other page?

I think that's correct. The current behavior shouldn't change. This expression was just moved from lower and named.

…astic#96087) ## Summary This PR implements several items from point 8 in elastic/observability-design#32 The changes to modal titles and success/error behavior are only for bulk upgrade in this PR. Once we confirm the pattern, I'll apply it to unenroll and reassign in a follow up PR. - [x] Disable the checkbox for agents enrolled in a hosted agent policy. We don't need to provide a tooltip description since the Agent policy "lock" icon appears in the table row. - [x] If a user selects the top-left checkbox to select all agents on the page, and then clicks "select everything on all pages", we don't need to provide a count for total number of agents selected. The bulk actions button can say "all agents selected" (as discussed, calculating the total number of agents is problematic and can be tough on performance). Choosing a bulk action should filter out / not include any agents that are enrolled in a hosted agent policy. - [x] Related to calculating total number of agents, we previously showed a count in the action modal's title. In the case where users have selected everything on all pages, the title can just say "all selected agents" -> i.e. "upgrade all selected agents" - [x] If the result of a bulk action has mixed results, as in some percentage of agents are successful but others fail, show a warning toast that indicates how many succeeded and how many failed. See screenshot below. - [x] Change the "experimental" badge for the upgrade agent action modal to be an icon only badge. You can use the `beaker` icon. The badge should use the same tooltip description that we use today indicating that this action is experimental. ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ## Per feature details & screenshots <details> <summary>Disable the checkbox for agents enrolled in a hosted agent policy.</summary> <img width="1016" alt="Screen Shot 2021-04-02 at 10 35 38 AM" src="https://user-images.githubusercontent.com/57655/113425437-d9e9e680-939f-11eb-9b1b-423d78dbc8fc.png"> <blockquote>We don't need to provide a tooltip description since the Agent policy "lock" icon appears in the table row.</blockquote> I left the description in until we implement the "lock" icon. </details> <details> <summary>If a user selects the top-left checkbox to select all agents on the page, and then clicks "select everything on all pages", ... the bulk actions button can say "all agents selected" </summary> <img width="998" alt="Screen Shot 2021-04-02 at 9 20 28 AM" src="https://user-images.githubusercontent.com/57655/113426911-1d455480-93a2-11eb-98e2-5a328ebd9d97.png"> <img width="1010" alt="Screen Shot 2021-04-02 at 9 20 45 AM" src="https://user-images.githubusercontent.com/57655/113426912-1d455480-93a2-11eb-92f3-7036d9e95f0c.png"> <blockquote>Choosing a bulk action should filter out / not include any agents that are enrolled in a hosted agent policy.</blockquote> <img width="529" alt="Screen Shot 2021-04-02 at 10 58 43 AM" src="https://user-images.githubusercontent.com/57655/113427313-cb50fe80-93a2-11eb-948a-68dc165e567b.png"> <img width="593" alt="Screen Shot 2021-04-02 at 11 00 44 AM" src="https://user-images.githubusercontent.com/57655/113427317-cbe99500-93a2-11eb-9701-48a598350d4b.png"> <img width="1021" alt="Screen Shot 2021-04-02 at 10 59 27 AM" src="https://user-images.githubusercontent.com/57655/113427315-cb50fe80-93a2-11eb-8af3-822a23b91940.png"> <em>There are 7 rows, but only 6 were attempted because 1 is managed</em> </details> <details> <summary>When users have selected everything on all pages, the title can just say "all selected agents" -> i.e. "upgrade all selected agents"</summary> <img width="843" alt="Screen Shot 2021-04-01 at 11 35 06 AM" src="https://user-images.githubusercontent.com/57655/113344391-04379780-92ff-11eb-86f8-62cdc0cde69d.png"> <em>the text inside the modal was also updated per the screenshots</em> <h4>Single agent case</h4> <img width="796" alt="Screen Shot 2021-04-01 at 11 35 18 AM" src="https://user-images.githubusercontent.com/57655/113344393-04d02e00-92ff-11eb-8b7e-1992a1ac695e.png"> <h4>Multiple items but not "all"</h4> <img width="786" alt="Screen Shot 2021-04-01 at 11 35 33 AM" src="https://user-images.githubusercontent.com/57655/113344394-04d02e00-92ff-11eb-8f67-2f03fe8014c3.png"> </details> <details> <summary>If the result of a bulk action has mixed results, as in some percentage of agents are successful but others fail, show a warning toast that indicates how many succeeded and how many failed</summary> <h4>Mixed success & failure: show warning</h4> <img width="1021" alt="Screen Shot 2021-04-02 at 10 59 27 AM" src="https://user-images.githubusercontent.com/57655/113427315-cb50fe80-93a2-11eb-8af3-822a23b91940.png"> <h4>All succeed. Variants for multiple vs all selected</h4> <img width="376" alt="Screen Shot 2021-04-02 at 11 26 46 AM" src="https://user-images.githubusercontent.com/57655/113432299-2129a480-93ab-11eb-93f1-9a3edf2f1a2d.png"> <img width="342" alt="Screen Shot 2021-04-02 at 11 59 44 AM" src="https://user-images.githubusercontent.com/57655/113432300-21c23b00-93ab-11eb-85a8-222cef29a941.png"> <h4>All fail. Variants for multiple vs all selected</h4> <img width="381" alt="Screen Shot 2021-04-02 at 11 14 48 AM" src="https://user-images.githubusercontent.com/57655/113428661-2daafe80-93a5-11eb-86b4-1993ebf9d2fa.png"> <img width="351" alt="Screen Shot 2021-04-02 at 11 19 17 AM" src="https://user-images.githubusercontent.com/57655/113428746-592de900-93a5-11eb-9cc0-5d919afd6d59.png"> </details> <details> <summary>Change the "experimental" badge for the upgrade agent action modal to be an icon only badge. You can use the `beaker` icon. The badge should use the same tooltip description that we use today indicating that this action is experimental.</summary> <img width="843" alt="Screen Shot 2021-04-01 at 11 35 06 AM" src="https://user-images.githubusercontent.com/57655/113344391-04379780-92ff-11eb-86f8-62cdc0cde69d.png"> </details> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-04-06T14:24:55Z

💚 Backport successful

✅ 7.x / #96312

This backport PR will be merged automatically after passing CI.

…6087) (#96312) ## Summary This PR implements several items from point 8 in elastic/observability-design#32 The changes to modal titles and success/error behavior are only for bulk upgrade in this PR. Once we confirm the pattern, I'll apply it to unenroll and reassign in a follow up PR. - [x] Disable the checkbox for agents enrolled in a hosted agent policy. We don't need to provide a tooltip description since the Agent policy "lock" icon appears in the table row. - [x] If a user selects the top-left checkbox to select all agents on the page, and then clicks "select everything on all pages", we don't need to provide a count for total number of agents selected. The bulk actions button can say "all agents selected" (as discussed, calculating the total number of agents is problematic and can be tough on performance). Choosing a bulk action should filter out / not include any agents that are enrolled in a hosted agent policy. - [x] Related to calculating total number of agents, we previously showed a count in the action modal's title. In the case where users have selected everything on all pages, the title can just say "all selected agents" -> i.e. "upgrade all selected agents" - [x] If the result of a bulk action has mixed results, as in some percentage of agents are successful but others fail, show a warning toast that indicates how many succeeded and how many failed. See screenshot below. - [x] Change the "experimental" badge for the upgrade agent action modal to be an icon only badge. You can use the `beaker` icon. The badge should use the same tooltip description that we use today indicating that this action is experimental. ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ## Per feature details & screenshots <details> <summary>Disable the checkbox for agents enrolled in a hosted agent policy.</summary> <img width="1016" alt="Screen Shot 2021-04-02 at 10 35 38 AM" src="https://user-images.githubusercontent.com/57655/113425437-d9e9e680-939f-11eb-9b1b-423d78dbc8fc.png"> <blockquote>We don't need to provide a tooltip description since the Agent policy "lock" icon appears in the table row.</blockquote> I left the description in until we implement the "lock" icon. </details> <details> <summary>If a user selects the top-left checkbox to select all agents on the page, and then clicks "select everything on all pages", ... the bulk actions button can say "all agents selected" </summary> <img width="998" alt="Screen Shot 2021-04-02 at 9 20 28 AM" src="https://user-images.githubusercontent.com/57655/113426911-1d455480-93a2-11eb-98e2-5a328ebd9d97.png"> <img width="1010" alt="Screen Shot 2021-04-02 at 9 20 45 AM" src="https://user-images.githubusercontent.com/57655/113426912-1d455480-93a2-11eb-92f3-7036d9e95f0c.png"> <blockquote>Choosing a bulk action should filter out / not include any agents that are enrolled in a hosted agent policy.</blockquote> <img width="529" alt="Screen Shot 2021-04-02 at 10 58 43 AM" src="https://user-images.githubusercontent.com/57655/113427313-cb50fe80-93a2-11eb-948a-68dc165e567b.png"> <img width="593" alt="Screen Shot 2021-04-02 at 11 00 44 AM" src="https://user-images.githubusercontent.com/57655/113427317-cbe99500-93a2-11eb-9701-48a598350d4b.png"> <img width="1021" alt="Screen Shot 2021-04-02 at 10 59 27 AM" src="https://user-images.githubusercontent.com/57655/113427315-cb50fe80-93a2-11eb-8af3-822a23b91940.png"> <em>There are 7 rows, but only 6 were attempted because 1 is managed</em> </details> <details> <summary>When users have selected everything on all pages, the title can just say "all selected agents" -> i.e. "upgrade all selected agents"</summary> <img width="843" alt="Screen Shot 2021-04-01 at 11 35 06 AM" src="https://user-images.githubusercontent.com/57655/113344391-04379780-92ff-11eb-86f8-62cdc0cde69d.png"> <em>the text inside the modal was also updated per the screenshots</em> <h4>Single agent case</h4> <img width="796" alt="Screen Shot 2021-04-01 at 11 35 18 AM" src="https://user-images.githubusercontent.com/57655/113344393-04d02e00-92ff-11eb-8b7e-1992a1ac695e.png"> <h4>Multiple items but not "all"</h4> <img width="786" alt="Screen Shot 2021-04-01 at 11 35 33 AM" src="https://user-images.githubusercontent.com/57655/113344394-04d02e00-92ff-11eb-8f67-2f03fe8014c3.png"> </details> <details> <summary>If the result of a bulk action has mixed results, as in some percentage of agents are successful but others fail, show a warning toast that indicates how many succeeded and how many failed</summary> <h4>Mixed success & failure: show warning</h4> <img width="1021" alt="Screen Shot 2021-04-02 at 10 59 27 AM" src="https://user-images.githubusercontent.com/57655/113427315-cb50fe80-93a2-11eb-8af3-822a23b91940.png"> <h4>All succeed. Variants for multiple vs all selected</h4> <img width="376" alt="Screen Shot 2021-04-02 at 11 26 46 AM" src="https://user-images.githubusercontent.com/57655/113432299-2129a480-93ab-11eb-93f1-9a3edf2f1a2d.png"> <img width="342" alt="Screen Shot 2021-04-02 at 11 59 44 AM" src="https://user-images.githubusercontent.com/57655/113432300-21c23b00-93ab-11eb-85a8-222cef29a941.png"> <h4>All fail. Variants for multiple vs all selected</h4> <img width="381" alt="Screen Shot 2021-04-02 at 11 14 48 AM" src="https://user-images.githubusercontent.com/57655/113428661-2daafe80-93a5-11eb-86b4-1993ebf9d2fa.png"> <img width="351" alt="Screen Shot 2021-04-02 at 11 19 17 AM" src="https://user-images.githubusercontent.com/57655/113428746-592de900-93a5-11eb-9cc0-5d919afd6d59.png"> </details> <details> <summary>Change the "experimental" badge for the upgrade agent action modal to be an icon only badge. You can use the `beaker` icon. The badge should use the same tooltip description that we use today indicating that this action is experimental.</summary> <img width="843" alt="Screen Shot 2021-04-01 at 11 35 06 AM" src="https://user-images.githubusercontent.com/57655/113344391-04379780-92ff-11eb-86f8-62cdc0cde69d.png"> </details> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: John Schulz <john.schulz@elastic.co>

dikshachauhan-qasource · 2021-04-08T13:39:49Z

Hi @EricDavisX

We have validated above merges on latest 8.0 snapshot environment and found below changes working fine.

After converting a user created policy under which agent was installed to Managed policy using API, we have observed following changes working fine.

Validation completed on :

Check box for managed host is disabled on Agent list page. hence unable to select using bulk options.
bulk actions button changed to "all agents selected", When everything selected, using modal title "select everything on all pages", from '*agents selected'
For bulk action, we observed action modal to upgrade agents wrt confirmation pop up working fine as per mocks provided.
The beaker icon is displayed for "experimental" badge on upgrade agent action modal.

Testing in-progress on:
5. Further, we have validated pop messages for bulk upgrade actions. Please refer below screenshots:

We are in middle of validating these pop-ups for now and will confirm complete testing once done on this.

Thanks
QAS

Can't select managed agent. Bulk upgrade agent UI changes

5711a80

jfsiii added Team:Fleet Team label for Observability Data Collection Fleet team v7.13.0 v8.0.0 labels Apr 1, 2021

hbharding reviewed Apr 1, 2021

View reviewed changes

...ins/fleet/public/applications/fleet/sections/agents/components/agent_upgrade_modal/index.tsx Outdated Show resolved Hide resolved

John Schulz added 2 commits April 1, 2021 20:40

Fix(?) i18n issues

376a7d4

Switch message from 'upgrades' to 'will upgrade'

606f3e6

Merge branch 'master' into 90437-bulk-upgrade-ui-changes

6925b0f

jfsiii requested a review from hbharding April 2, 2021 16:18

jfsiii marked this pull request as ready for review April 2, 2021 16:18

jfsiii requested a review from a team as a code owner April 2, 2021 16:18

jfsiii added the release_note:skip Skip the PR/issue when compiling release notes label Apr 2, 2021

Fix two i18n template issues

d3280ea

This was referenced Apr 2, 2021

[Fleet] [Managed Policies] Bulk actions changes #90437

Closed

[Fleet] UI changes related to hosted agent policies #91906

Closed

[Fleet] Hide many actions for hosted agent policies #96160

Merged

jfsiii self-assigned this Apr 5, 2021

Merge branch 'master' into 90437-bulk-upgrade-ui-changes

03d94ac

hbharding approved these changes Apr 5, 2021

View reviewed changes

jfsiii added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 5, 2021

jfsiii enabled auto-merge (squash) April 5, 2021 18:17

nchaulet reviewed Apr 6, 2021

View reviewed changes

nchaulet approved these changes Apr 6, 2021

View reviewed changes

jfsiii merged commit 357c4a5 into elastic:master Apr 6, 2021

kibanamachine mentioned this pull request Apr 6, 2021

[7.x] [Fleet] Can't select managed agent. Bulk upgrade agent UI changes (#96087) #96312

Merged

jfsiii deleted the 90437-bulk-upgrade-ui-changes branch April 6, 2021 17:09

EricDavisX mentioned this pull request Apr 7, 2021

[Fleet] Managed Agent Policy #88688

Merged

17 tasks

dikshachauhan-qasource mentioned this pull request May 4, 2021

[Fleet] Inappropriate error message shows up on upgrading non-upgradable agents through bulk option. #99187

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fleet] Can't select managed agent. Bulk upgrade agent UI changes #96087

[Fleet] Can't select managed agent. Bulk upgrade agent UI changes #96087

jfsiii commented Apr 1, 2021 •

edited

Loading

jfsiii commented Apr 2, 2021

elasticmachine commented Apr 2, 2021

jfsiii commented Apr 5, 2021

kibanamachine commented Apr 5, 2021

jfsiii commented Apr 5, 2021

kibanamachine commented Apr 5, 2021

jfsiii commented Apr 5, 2021

kibanamachine commented Apr 5, 2021

jfsiii commented Apr 5, 2021

hbharding left a comment •

edited

Loading

kibanamachine commented Apr 5, 2021

nchaulet Apr 6, 2021

jfsiii Apr 6, 2021 •

edited

Loading

kibanamachine commented Apr 6, 2021

dikshachauhan-qasource commented Apr 8, 2021

[Fleet] Can't select managed agent. Bulk upgrade agent UI changes #96087

[Fleet] Can't select managed agent. Bulk upgrade agent UI changes #96087

Conversation

jfsiii commented Apr 1, 2021 • edited Loading

Summary

Checklist

Per feature details & screenshots

Single agent case

Multiple items but not "all"

Mixed success & failure: show warning

All succeed. Variants for multiple vs all selected

All fail. Variants for multiple vs all selected

jfsiii commented Apr 2, 2021

elasticmachine commented Apr 2, 2021

jfsiii commented Apr 5, 2021

kibanamachine commented Apr 5, 2021

jfsiii commented Apr 5, 2021

kibanamachine commented Apr 5, 2021

jfsiii commented Apr 5, 2021

kibanamachine commented Apr 5, 2021

jfsiii commented Apr 5, 2021

hbharding left a comment • edited Loading

Choose a reason for hiding this comment

kibanamachine commented Apr 5, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

History

nchaulet Apr 6, 2021

Choose a reason for hiding this comment

jfsiii Apr 6, 2021 • edited Loading

Choose a reason for hiding this comment

kibanamachine commented Apr 6, 2021

💚 Backport successful

dikshachauhan-qasource commented Apr 8, 2021

jfsiii commented Apr 1, 2021 •

edited

Loading

hbharding left a comment •

edited

Loading

jfsiii Apr 6, 2021 •

edited

Loading