Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds links to advanced logging documentation from settings #96240

Merged

Conversation

TinaHeiligers
Copy link
Contributor

This PR is a follow up to #94993 and add links from the settings and breaking changes documentation.

Checklist

Delete any items that are not applicable to this PR.

  • Documentation was added for features that require explanation or tutorials

For maintainers

@TinaHeiligers TinaHeiligers added Feature:Logging release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Docs v7.13.0 v8.0.0 labels Apr 5, 2021
@TinaHeiligers TinaHeiligers marked this pull request as ready for review April 5, 2021 20:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@@ -118,7 +118,7 @@ logging:

[float]
==== Set log verbosity with root
*Details:* Previously logging output would be specified by `logging.silent` (none), `logging.quiet` (error messages only) and `logging.verbose` (all). With the new logging configuration, set the minimum required log level.
*Details:* Previously logging output would be specified by `logging.silent` (none), `logging.quiet` (error messages only) and `logging.verbose` (all). With the new logging configuration, set the minimum required {kibana-ref}/logging-service.html#log-level[log level].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Is it possible to use the standard asciidoc cross-references instead of relying on generated URL?
https://docs.asciidoctor.org/asciidoc/latest/syntax-quick-reference/#ex-xrefs
Should the file name change, the link is broken.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc we're linking to isn't in the same book so we have to use an external link here.

@TinaHeiligers TinaHeiligers added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 6, 2021
@TinaHeiligers TinaHeiligers merged commit 69f9d65 into elastic:master Apr 6, 2021
@TinaHeiligers TinaHeiligers deleted the core-docs/logging-add-links branch April 6, 2021 14:06
@kibanamachine
Copy link
Contributor

💔 Backport failed

❌ 7.x: Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 96240

TinaHeiligers added a commit to TinaHeiligers/kibana that referenced this pull request Apr 6, 2021
…6240)

# Conflicts:
#	docs/migration/migrate_8_0.asciidoc
TinaHeiligers added a commit that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Logging release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Docs v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants