[ML] Data Frame Analytics: adds functional tests for runtime fields support #96262
Conversation
alvarezmelissa87
added
:ml
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
| await testSubjects.existOrFail('mlDataFrameAnalyticsAdvancedRuntimeMappingsEditor'); | ||
| }, | ||
|
|
||
| // async enableRuntimeMappingsEditor() { |
There was a problem hiding this comment.
Should we get rid of this commented code?
There was a problem hiding this comment.
Oh good catch - thanks 68f8857
| // Not all lines may be visible in the editor and thus aceEditor may not return all lines. | ||
| // This means we might not get back valid JSON so we only test against the first few lines | ||
| // and see if the string matches. | ||
| const splicedAdvancedEditorValue = runtimeMappingsEditorString.split('\n').splice(0, 3); |
There was a problem hiding this comment.
Doesn't have to be a part of this PR, but since this piece is now used multiple times across different parts of ml/transform, I wonder if it would be beneficial for us to move this chunk into MachineLearningCommonUIProvider.
| JSON.stringify(testData.runtimeFields) | ||
| ); | ||
| await ml.dataFrameAnalyticsCreation.applyRuntimeMappings(); | ||
|
|
There was a problem hiding this comment.
Should we validate that uppercase_stab is showing up correctly in the wizard after this button is applied?
There was a problem hiding this comment.
Good call - checked in 68f8857
| JSON.stringify(testData.runtimeFields) | ||
| ); | ||
| await ml.dataFrameAnalyticsCreation.applyRuntimeMappings(); | ||
|
|
There was a problem hiding this comment.
Should we validate that lowercase_central_air is showing up correctly in the wizard after this button is applied?
There was a problem hiding this comment.
We should probably have a check either in this test or another dedicated test if for example, the histogram charts for runtime fields like lowercase_central_air is showing up correctly once the mappings is applied.
There was a problem hiding this comment.
Checking in 68f8857
Agreed - this is a basic runtime fields tests. I'll add in more advanced ones in a follow up
| JSON.stringify(testData.runtimeFields) | ||
| ); | ||
| await ml.dataFrameAnalyticsCreation.applyRuntimeMappings(); | ||
|
|
There was a problem hiding this comment.
Should we validate that uppercase_y is showing up correctly in the wizard after this button is applied?
There was a problem hiding this comment.
Checked in 68f8857
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
|
LGTM 🎉 |
…upport (elastic#96262) * add basic runtime mapping functional tests to analyics * confirm runtime mapping added correctly.
Summary
Related meta issue: #94243
Adds initial runtime fields functional tests for analytics creation wizard.
Flaky test runner build: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1428/
Checklist
Delete any items that are not applicable to this PR.