-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security] Adds pre-packaged rule updates through the "Prebuilt Security Detection Rules" Fleet integration #96698
Merged
rw-access
merged 11 commits into
elastic:master
from
rw-access:install-security-rules-via-pkg
Apr 14, 2021
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
850856d
Make the prepackaged rules functions async
rw-access 38ba797
Fix type for getPrepackagedRules mock
rw-access 93e3159
Install updates from saved objects & FS
rw-access 4a855ee
Merge remote-tracking branch 'origin/master' into install-security-ru…
rw-access a1febb9
Mock getLatestPrepackagedRules instead of getPrepackagedRules
rw-access dc48e1a
Cleanup ruleAssetSavedObjectsClientFactory.all
rw-access 1e56114
Fix comment for "most recent version"
rw-access 3df98ad
Switch to ruleMap.get() for less typescript errors
rw-access 84248b3
Remove unneeded constants
rw-access 41536f0
Fix SO.attributes sig and use custom validation
rw-access df517f8
Merge branch 'master' into install-security-rules-via-pkg
kibanamachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
...ns/security_solution/server/lib/detection_engine/rules/rule_asset_saved_objects_client.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { | ||
SavedObjectsClientContract, | ||
SavedObjectsFindOptions, | ||
SavedObjectsFindResponse, | ||
} from '../../../../../../../src/core/server'; | ||
import { ruleAssetSavedObjectType } from '../rules/saved_object_mappings'; | ||
import { IRuleAssetSavedObject } from '../rules/types'; | ||
|
||
const DEFAULT_PAGE_SIZE = 100; | ||
|
||
export interface RuleAssetSavedObjectsClient { | ||
find: ( | ||
options?: Omit<SavedObjectsFindOptions, 'type'> | ||
) => Promise<SavedObjectsFindResponse<IRuleAssetSavedObject>>; | ||
all: () => Promise<IRuleAssetSavedObject[]>; | ||
} | ||
|
||
export const ruleAssetSavedObjectsClientFactory = ( | ||
savedObjectsClient: SavedObjectsClientContract | ||
): RuleAssetSavedObjectsClient => { | ||
return { | ||
find: (options) => | ||
savedObjectsClient.find<IRuleAssetSavedObject>({ | ||
...options, | ||
type: ruleAssetSavedObjectType, | ||
}), | ||
all: async () => { | ||
const finder = savedObjectsClient.createPointInTimeFinder({ | ||
perPage: DEFAULT_PAGE_SIZE, | ||
type: ruleAssetSavedObjectType, | ||
}); | ||
const responses: IRuleAssetSavedObject[] = []; | ||
for await (const response of finder.find()) { | ||
responses.push(...response.saved_objects.map((so) => so as IRuleAssetSavedObject)); | ||
} | ||
await finder.close(); | ||
return responses; | ||
}, | ||
}; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bummer the
.find
doesn't take a template input and forces you to do thatso as IRuleAssetSavedObject
below.