Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency @elastic/charts to v28.2.0 (master) #97005

Merged
merged 5 commits into from
Apr 15, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 13, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@elastic/charts 28.0.1 -> 28.2.0 age adoption passing confidence

Release Notes

elastic/elastic-charts

Compare Source

v28.2.0

Bug Fixes
Features

v28.1.0

Bug Fixes
Features

28.0.1 (2021-04-06)

Bug Fixes

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0 labels Apr 13, 2021
@renovate renovate bot requested review from markov00 and nickofthyme April 13, 2021 16:46
@renovate renovate bot requested a review from a team April 13, 2021 21:19
@nickofthyme
Copy link
Contributor

@elasticmachine merge upstream

Comment on lines +220 to +229
[
{
groupByRollup: 6,
value: 6,
depth: 1,
path: [],
sortIndex: 1,
smAccessorValue: '',
},
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing smAccessorValue from new partition small multiples

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lens code changes LGTM, but it seems like this broke the way we do functional tests. Let me know whether I should take a deeper look here.

retry.try timeout: NoSuchElementError: no such element: Unable to locate element: {"method":"css selector","selector":"[data-ech-series-name="Count"] .echLegendItem__color"}

@flash1293
Copy link
Contributor

@elasticmachine merge upstream

@markov00 markov00 self-assigned this Apr 14, 2021
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This elastic/elastic-charts#1087 introduced an internal change.
I've checked the error and is easily visible when opening the Log sample dashboard.
The problem happens when using dual axis chart, in particular this part in src/plugins/vis_type_xy/public/utils/render_all_series.tsx create the issue in with the new code

// needed to seperate stacked and non-stacked bars into unique pseudo groups
      const pseudoGroupId = isStacked ? `__pseudo_stacked_group-${groupId}__` : groupId;
      // set domain of stacked groups to use actual groupId not pseudo groupdId
      const useDefaultGroupDomain = isStacked ? groupId : undefined;

I'm start investigating locally on the chart lib about that case

@markov00
Copy link
Member

@elasticmachine run elasticsearch-ci/docs

@nickofthyme nickofthyme changed the title Update dependency @elastic/charts to v28.1.0 (master) Update dependency @elastic/charts to v28.2.0 (master) Apr 15, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 379.7KB 380.1KB +396.0B
kbnUiSharedDeps-elastic 3.3MB 3.3MB +6.7KB
kbnUiSharedDeps-js 6.7MB 6.7MB +16.0B
total +7.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @markov00

@markov00 markov00 self-requested a review April 15, 2021 15:13
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markov00 markov00 self-requested a review April 15, 2021 20:33
@markov00 markov00 merged commit ad25fb3 into master Apr 15, 2021
@markov00 markov00 deleted the renovate/master-@elasticcharts branch April 15, 2021 20:34
markov00 added a commit to markov00/kibana that referenced this pull request Apr 15, 2021
* Update dependency @elastic/charts to v28.2.0

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: nickofthyme <nick.ryan.partridge@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
markov00 added a commit that referenced this pull request Apr 15, 2021
* Update dependency @elastic/charts to v28.2.0

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: nickofthyme <nick.ryan.partridge@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: nickofthyme <nick.ryan.partridge@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow passing description props to <canvas> element Pie chart vislib replacement functional tests
5 participants