Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use doc links service for Canvas #97059

Merged
merged 3 commits into from
Apr 19, 2021
Merged

Use doc links service for Canvas #97059

merged 3 commits into from
Apr 19, 2021

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Apr 13, 2021 •
edited
Loading

Summary

Related to #88107

This PR removes the hard-coded documentation links within the Canvas app and uses the doc link service instead.

@lcawl lcawl added the WIP Work in progress label Apr 13, 2021
@lcawl lcawl mentioned this pull request Apr 13, 2021
Closed
@lcawl lcawl added Feature:Canvas v7.13.0 v8.0.0 and removed WIP Work in progress labels Apr 16, 2021
@lcawl
Copy link
Contributor Author

lcawl commented Apr 16, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@lcawl lcawl marked this pull request as ready for review April 16, 2021 01:26
@lcawl lcawl requested review from a team as code owners April 16, 2021 01:26
@kibanamachine kibanamachine added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Apr 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@lcawl
Copy link
Contributor Author

lcawl commented Apr 19, 2021

@elasticmachine merge upstream

@lcawl lcawl added the release_note:skip Skip the PR/issue when compiling release notes label Apr 19, 2021
cqliu1
cqliu1 approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@cqliu1 cqliu1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 This uses the doc links service for our documentation link in the global nav help menu, but we've got some other hardcoded links we should also convert to using this service. I think this is a good start, and we can address those other links in a follow up PR. I'll file an issue to track those links.

@cqliu1 cqliu1 mentioned this pull request Apr 19, 2021
Closed
6 tasks
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
canvas 1086 1085 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.2MB 1.2MB -185.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 381.0KB 381.2KB +114.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl added enhancement New value added to drive a business result impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort labels Apr 19, 2021
@lcawl lcawl merged commit 7927923 into elastic:master Apr 19, 2021
@lcawl lcawl deleted the canvas-links branch April 19, 2021 20:02
@lcawl lcawl mentioned this pull request Apr 19, 2021
Merged
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 97059 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 21, 2021
@lcawl lcawl added the backport:skip This commit does not require backporting label Apr 21, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 21, 2021
@gtback gtback mentioned this pull request May 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cqliu1 cqliu1 cqliu1 approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting enhancement New value added to drive a business result Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lcawl @kibanamachine @elasticmachine @pgayvallet @cqliu1