[Maps][File upload] fix layer in preview mode shows different results after uploading geojson file when feature-count exceeds ES-search limit #97157

nreese · 2021-04-14T17:16:15Z

This PR updates the file upload flow.

Previously, the preview layer would automatically switched from file preview to the Elasticsearch document layer when the upload process completed. This can be a very visually jaunting process since the preview may show points while the Elasticasearch document layer may show clusters.

This PR updates the file upload flow to only switch from the file preview to the Elasticsearch document layer after the user clicks "Add as document layer" button to avoid any drastic changes until a user has performed an action and knows why the layer is changing.

… after uploading geojson file when feature-count exceeds ES-search limit

elasticmachine · 2021-04-14T17:16:18Z

Pinging @elastic/kibana-gis (Team:Geo)

x-pack/plugins/file_upload/public/components/json_upload_and_parse.tsx

x-pack/plugins/maps/public/classes/layers/file_upload_wizard/config.tsx

kindsun · 2021-04-15T15:41:06Z

x-pack/plugins/maps/public/connected_components/add_layer_panel/view.tsx

+      : [
+          {
+            id: ADD_LAYER_STEP_ID,
+            label: ADD_LAYER_STEP_LABEL,
+          },
+        ];


If all layers ultimately end in an "Add layer step", what's the point in overriding this with prereq steps that include an add layer step vs. always including it here as we did before?

I did this so ClientFileCreateSourceEditor would know when the final step without needing to know about ADD_LAYER_STEP_ID since ADD_LAYER_STEP_ID seemed like an internal detail in AddLayerPanel.

I will revert this change and instead, pass isOnFinalStep to renderWizard since that is the information that is needed by ClientFileCreateSourceEditor. That way, ADD_LAYER_STEP_ID is the final step even when prerequisiteSteps are provided.

kindsun · 2021-04-15T15:42:45Z

First pass looks good. The extra step makes sense to me and it's a nice transition from preview to docs 👍

kindsun

Overall I think this is a nicely improved flow. Some minor comments. Worked well in local tests. lgtm!

code review
tested locally in chrome

kindsun · 2021-04-15T16:54:25Z

@elasticmachine merge upstream

kibanamachine · 2021-04-15T21:09:22Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fileUpload`	788.7KB	789.1KB	+387.0B
`maps`	2.6MB	2.6MB	+570.0B
total			+957.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`fileUpload`	13.8KB	14.0KB	+201.0B

Unknown metric groups

API count

id	before	after	diff
`actions`	-	113	+113
`advancedSettings`	-	18	+18
`alerting`	-	200	+200
`apm`	-	35	+35
`apmOss`	-	38	+38
`banners`	-	9	+9
`beatsManagement`	-	2	+2
`bfetch`	-	58	+58
`canvas`	-	4	+4
`cases`	-	2	+2
`charts`	-	157	+157
`cloud`	-	19	+19
`console`	-	2	+2
`core`	-	2168	+2168
`dashboard`	-	138	+138
`dashboardEnhanced`	-	51	+51
`dashboardMode`	-	11	+11
`data`	-	3436	+3436
`dataEnhanced`	-	52	+52
`devTools`	-	9	+9
`discover`	-	61	+61
`discoverEnhanced`	-	39	+39
`embeddable`	-	426	+426
`embeddableEnhanced`	-	14	+14
`encryptedSavedObjects`	-	20	+20
`enterpriseSearch`	-	2	+2
`esUiShared`	-	84	+84
`eventLog`	-	70	+70
`expressions`	-	1755	+1755
`features`	-	199	+199
`fileUpload`	-	180	+180
`fleet`	-	1075	+1075
`globalSearch`	-	67	+67
`home`	-	91	+91
`indexLifecycleManagement`	-	5	+5
`indexManagement`	-	162	+162
`indexPatternFieldEditor`	-	29	+29
`indexPatternManagement`	-	46	+46
`infra`	-	14	+14
`ingestPipelines`	-	9	+9
`inspector`	-	97	+97
`kibanaLegacy`	-	92	+92
`kibanaReact`	-	232	+232
`kibanaUtils`	-	465	+465
`lens`	-	160	+160
`licenseManagement`	-	3	+3
`licensing`	-	116	+116
`lists`	-	251	+251
`management`	-	35	+35
`maps`	-	182	+182
`mapsEms`	-	69	+69
`ml`	-	343	+343
`monitoring`	-	9	+9
`navigation`	-	29	+29
`newsfeed`	-	17	+17
`observability`	-	176	+176
`osquery`	-	8	+8
`presentationUtil`	-	69	+69
`remoteClusters`	-	4	+4
`reporting`	-	127	+127
`rollup`	-	20	+20
`ruleRegistry`	-	52	+52
`runtimeFields`	-	22	+22
`savedObjects`	-	173	+173
`savedObjectsManagement`	-	91	+91
`savedObjectsTagging`	-	54	+54
`savedObjectsTaggingOss`	-	81	+81
`security`	-	79	+79
`securityOss`	-	11	+11
`securitySolution`	-	99	+99
`share`	-	66	+66
`snapshotRestore`	-	22	+22
`spaces`	-	82	+82
`spacesOss`	-	64	+64
`stackAlerts`	-	4	+4
`taskManager`	-	41	+41
`telemetry`	-	41	+41
`telemetryCollectionManager`	-	24	+24
`telemetryCollectionXpack`	-	1	+1
`telemetryManagementSection`	-	13	+13
`timelines`	-	6	+6
`triggersActionsUi`	-	221	+221
`uiActions`	-	127	+127
`uiActionsEnhanced`	-	185	+185
`uptime`	-	5	+5
`urlForwarding`	-	14	+14
`usageCollection`	-	53	+53
`visTypeTimeseries`	-	7	+7
`visualizations`	-	212	+212
total			+15224

API count missing comments

id	before	after	diff
`actions`	-	113	+113
`advancedSettings`	-	17	+17
`alerting`	-	200	+200
`apm`	-	35	+35
`apmOss`	-	38	+38
`banners`	-	9	+9
`beatsManagement`	-	2	+2
`bfetch`	-	47	+47
`canvas`	-	3	+3
`cases`	-	2	+2
`charts`	-	132	+132
`cloud`	-	19	+19
`console`	-	2	+2
`core`	-	989	+989
`dashboard`	-	126	+126
`dashboardEnhanced`	-	50	+50
`dashboardMode`	-	11	+11
`data`	-	2944	+2944
`dataEnhanced`	-	34	+34
`devTools`	-	8	+8
`discover`	-	48	+48
`discoverEnhanced`	-	37	+37
`embeddable`	-	361	+361
`embeddableEnhanced`	-	14	+14
`encryptedSavedObjects`	-	18	+18
`enterpriseSearch`	-	2	+2
`esUiShared`	-	82	+82
`eventLog`	-	70	+70
`expressions`	-	1364	+1364
`features`	-	89	+89
`fileUpload`	-	180	+180
`fleet`	-	985	+985
`globalSearch`	-	13	+13
`home`	-	67	+67
`indexLifecycleManagement`	-	5	+5
`indexManagement`	-	157	+157
`indexPatternFieldEditor`	-	27	+27
`indexPatternManagement`	-	46	+46
`infra`	-	11	+11
`ingestPipelines`	-	9	+9
`inspector`	-	77	+77
`kibanaLegacy`	-	84	+84
`kibanaReact`	-	207	+207
`kibanaUtils`	-	301	+301
`lens`	-	149	+149
`licenseManagement`	-	3	+3
`licensing`	-	40	+40
`lists`	-	234	+234
`management`	-	35	+35
`maps`	-	181	+181
`mapsEms`	-	69	+69
`ml`	-	339	+339
`monitoring`	-	9	+9
`navigation`	-	29	+29
`newsfeed`	-	17	+17
`observability`	-	176	+176
`osquery`	-	8	+8
`presentationUtil`	-	67	+67
`remoteClusters`	-	4	+4
`reporting`	-	126	+126
`rollup`	-	20	+20
`ruleRegistry`	-	52	+52
`runtimeFields`	-	17	+17
`savedObjects`	-	159	+159
`savedObjectsManagement`	-	80	+80
`savedObjectsTagging`	-	50	+50
`savedObjectsTaggingOss`	-	42	+42
`security`	-	38	+38
`securityOss`	-	8	+8
`securitySolution`	-	90	+90
`share`	-	60	+60
`snapshotRestore`	-	22	+22
`spaces`	-	65	+65
`spacesOss`	-	29	+29
`stackAlerts`	-	4	+4
`taskManager`	-	16	+16
`telemetry`	-	37	+37
`telemetryCollectionManager`	-	24	+24
`telemetryCollectionXpack`	-	1	+1
`telemetryManagementSection`	-	12	+12
`timelines`	-	6	+6
`triggersActionsUi`	-	212	+212
`uiActions`	-	88	+88
`uiActionsEnhanced`	-	135	+135
`uptime`	-	5	+5
`urlForwarding`	-	14	+14
`usageCollection`	-	46	+46
`visTypeTimeseries`	-	7	+7
`visualizations`	-	194	+194
total			+12054

API count with any type

id	before	after	diff
`bfetch`	-	1	+1
`charts`	-	2	+2
`core`	-	147	+147
`dashboard`	-	1	+1
`data`	-	81	+81
`embeddable`	-	2	+2
`esUiShared`	-	4	+4
`expressions`	-	44	+44
`fileUpload`	-	6	+6
`fleet`	-	16	+16
`indexManagement`	-	12	+12
`inspector`	-	6	+6
`kibanaLegacy`	-	3	+3
`kibanaUtils`	-	3	+3
`maps`	-	2	+2
`mapsEms`	-	1	+1
`ml`	-	14	+14
`reporting`	-	1	+1
`ruleRegistry`	-	1	+1
`savedObjects`	-	3	+3
`share`	-	1	+1
`snapshotRestore`	-	1	+1
`triggersActionsUi`	-	1	+1
`visualizations`	-	11	+11
total			+364

Non-exported public API item count

id	before	after	diff
`actions`	-	6	+6
`advancedSettings`	-	1	+1
`alerting`	-	9	+9
`apm`	-	8	+8
`bfetch`	-	2	+2
`canvas`	-	2	+2
`cases`	-	1	+1
`charts`	-	2	+2
`core`	-	29	+29
`dashboard`	-	9	+9
`data`	-	76	+76
`dataEnhanced`	-	2	+2
`devTools`	-	2	+2
`discover`	-	6	+6
`discoverEnhanced`	-	2	+2
`embeddable`	-	3	+3
`encryptedSavedObjects`	-	4	+4
`esUiShared`	-	4	+4
`eventLog`	-	4	+4
`expressions`	-	7	+7
`features`	-	1	+1
`fleet`	-	10	+10
`globalSearch`	-	6	+6
`home`	-	8	+8
`indexManagement`	-	4	+4
`indexPatternFieldEditor`	-	4	+4
`indexPatternManagement`	-	4	+4
`infra`	-	2	+2
`ingestPipelines`	-	4	+4
`inspector`	-	4	+4
`kibanaLegacy`	-	1	+1
`kibanaReact`	-	3	+3
`kibanaUtils`	-	8	+8
`lens`	-	12	+12
`licensing`	-	10	+10
`lists`	-	60	+60
`management`	-	4	+4
`maps`	-	16	+16
`ml`	-	34	+34
`navigation`	-	3	+3
`observability`	-	7	+7
`presentationUtil`	-	4	+4
`reporting`	-	18	+18
`ruleRegistry`	-	4	+4
`runtimeFields`	-	2	+2
`savedObjects`	-	5	+5
`savedObjectsManagement`	-	1	+1
`security`	-	10	+10
`securityOss`	-	3	+3
`securitySolution`	-	7	+7
`share`	-	3	+3
`snapshotRestore`	-	1	+1
`spaces`	-	3	+3
`taskManager`	-	3	+3
`telemetry`	-	3	+3
`telemetryCollectionManager`	-	4	+4
`timelines`	-	1	+1
`triggersActionsUi`	-	28	+28
`uiActions`	-	9	+9
`uiActionsEnhanced`	-	10	+10
`uptime`	-	3	+3
`usageCollection`	-	7	+7
`visTypeTimeseries`	-	2	+2
`visualizations`	-	6	+6
total			+521

History

💚 Build #120068 succeeded 0396f00
💚 Build #119712 succeeded 3108702
💔 Build #119699 failed d055541

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

… after uploading geojson file when feature-count exceeds ES-search limit (elastic#97157) * [Maps][File upload] fix layer in preview mode shows different results after uploading geojson file when feature-count exceeds ES-search limit * i18n clean up * review feedback Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

… after uploading geojson file when feature-count exceeds ES-search limit (#97157) (#97325) * [Maps][File upload] fix layer in preview mode shows different results after uploading geojson file when feature-count exceeds ES-search limit * i18n clean up * review feedback Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

[Maps][File upload] fix layer in preview mode shows different results…

d055541

… after uploading geojson file when feature-count exceeds ES-search limit

nreese added release_note:fix [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.13.0 labels Apr 14, 2021

nreese requested a review from kindsun April 14, 2021 17:16

i18n clean up

3108702

kindsun reviewed Apr 15, 2021

View reviewed changes

x-pack/plugins/file_upload/public/components/json_upload_and_parse.tsx Show resolved Hide resolved

kindsun reviewed Apr 15, 2021

View reviewed changes

x-pack/plugins/maps/public/classes/layers/file_upload_wizard/config.tsx Outdated Show resolved Hide resolved

kindsun reviewed Apr 15, 2021

View reviewed changes

kindsun approved these changes Apr 15, 2021

View reviewed changes

kibanamachine and others added 2 commits April 15, 2021 12:54

Merge branch 'master' into add_document_layer

0396f00

review feedback

bbc07a6

nreese merged commit f972174 into elastic:master Apr 15, 2021

nreese mentioned this pull request Apr 15, 2021

[7.x] [Maps][File upload] fix layer in preview mode shows different results after uploading geojson file when feature-count exceeds ES-search limit (#97157) #97325

Merged

kindsun mentioned this pull request May 19, 2021

[Maps][File upload] Add refresh to File Upload indexing calls #100367

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Maps][File upload] fix layer in preview mode shows different results after uploading geojson file when feature-count exceeds ES-search limit #97157

[Maps][File upload] fix layer in preview mode shows different results after uploading geojson file when feature-count exceeds ES-search limit #97157

nreese commented Apr 14, 2021 •

edited

Loading

elasticmachine commented Apr 14, 2021

kindsun Apr 15, 2021

nreese Apr 15, 2021

kindsun commented Apr 15, 2021

kindsun left a comment

kindsun commented Apr 15, 2021

kibanamachine commented Apr 15, 2021

API count

API count missing comments

API count with any type

Non-exported public API item count

[Maps][File upload] fix layer in preview mode shows different results after uploading geojson file when feature-count exceeds ES-search limit #97157

[Maps][File upload] fix layer in preview mode shows different results after uploading geojson file when feature-count exceeds ES-search limit #97157

Conversation

nreese commented Apr 14, 2021 • edited Loading

elasticmachine commented Apr 14, 2021

kindsun Apr 15, 2021

Choose a reason for hiding this comment

nreese Apr 15, 2021

Choose a reason for hiding this comment

kindsun commented Apr 15, 2021

kindsun left a comment

Choose a reason for hiding this comment

kindsun commented Apr 15, 2021

kibanamachine commented Apr 15, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

API count

API count missing comments

API count with any type

Non-exported public API item count

History

nreese commented Apr 14, 2021 •

edited

Loading