-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Canvas] Handle element changing into a filter #97890
Conversation
Pinging @elastic/kibana-presentation (Team:Presentation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Fixes #33605
If an expression is edited to become a filter, or a different type of filter, then the filter value on that element would become incorrect.
This fixes that issue by making sure the filter value on the element is of the correct type.
Steps to reproduce/test:
filters | render as=debug
, so you can see all the filter valuestimefilterControl compact=true column=@timestamp | render
Also try changing a dropdownFilter expression to a timeFilter expression and vice versa and ensure the correct filter value ends up on the element and shows in the debug.