Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solutions][Timeline] Added createFrom in action to hide #98144

Merged
merged 10 commits into from
Apr 29, 2021
Merged

[Security Solutions][Timeline] Added createFrom in action to hide #98144

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3230b6a
added createFrom in action to hide
semd Apr 23, 2021
006c81b
prettier configured
semd Apr 23, 2021
38d486c
tests to check timeline modal table actions
semd Apr 27, 2021
588e1c8
Merge branch 'master' into sergi-hide_create_template_action-97093
kibanamachine Apr 27, 2021
854faab
test changes and contant extract
semd Apr 28, 2021
e4d3f63
Merge branch 'sergi-hide_create_template_action-97093' of https://git…
semd Apr 28, 2021
ed6e0a3
removed unused dependency
semd Apr 28, 2021
f3c3035
Merge remote-tracking branch 'upstream/master' into sergi-hide_create…
semd Apr 28, 2021
19bf8f4
prevent adding empty column to timeline table when no action need
semd Apr 28, 2021
99ec69f
test updated
semd Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions x-pack/plugins/security_solution/public/detections/components/rules/query_bar/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ describe('QueryBarDefineRule', () => {
expect(wrapper.dive().find('[data-test-subj="query-bar-define-rule"]')).toHaveLength(1);
});

it('renders import query from saved timeline modal with no timeline action correctly', () => {
it('renders import query from saved timeline modal actions hidden correctly', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hooray! thank you

const Component = () => {
const field = useFormFieldMock();

Expand All @@ -84,8 +84,7 @@ describe('QueryBarDefineRule', () => {
</TestProviders>
);

const firstRow = wrapper.find('[data-test-subj="timelines-table"] table tbody tr').first();
const actionsCell = firstRow.find('.euiTableRowCell').last();
expect(actionsCell.find('.euiTableCellContent').isEmptyRender()).toBeTruthy();
expect(wrapper.find('[data-test-subj="open-duplicate"]').exists()).toBeFalsy();
expect(wrapper.find('[data-test-subj="create-from-template"]').exists()).toBeFalsy();
});
});