-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Detections] Update rule integration tests #98512
[Security Solution][Detections] Update rule integration tests #98512
Conversation
957c122
to
6ef7187
Compare
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small addition to the rule name override test, other than that it looks great. Thanks for fleshing out these tests!
}, | ||
], | ||
status: 'open', | ||
rule: fullSignal.signal.rule, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we want to check that signal.rule.name
is properly overridden with the value from the event.action
field. To avoid checking the rest of the fields you could do something like
rule: {
...fullSignal.signal.rule,
name: 'boot',
rule_name_override: 'event.action',
}
6532fd9
to
3db2841
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending CI pass
💚 Build SucceededMetrics [docs]Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: cc @dplumlee |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
#100960) Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>
Summary
Updates rule integration tests to compare full
_source
outputs instead of justsignal
outputs. Also addsrule_name_override
integration testsChecklist
Delete any items that are not applicable to this PR.
For maintainers