-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API DOCS] Telemetry #98610
[API DOCS] Telemetry #98610
Conversation
Pinging @elastic/kibana-core (Team:Core) |
Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry) |
}); | ||
|
||
it('returns true if lastReported is undefined', () => { | ||
const telemetryService = mockTelemetryService(); | ||
telemetryService.getIsOptedIn = jest.fn().mockReturnValue(true); | ||
const telemetrySender = new TelemetrySender(telemetryService); | ||
const shouldSendRerpot = telemetrySender['shouldSendReport'](); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure that was me with this faulty mac keyboard 😓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or me 😅 I have a spellchecker in my IDE because I'm always mixing up keystrokes... In mind, I think that I know what I'm doing, but my fingers think otherwise... 🤦
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :elasticheart:
9c4e799
to
5b0472a
Compare
💚 Build SucceededMetrics [docs]Public APIs missing comments
Any counts in public APIs
Page load bundle
History
To update your PR or re-run it, just comment with: |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Summary
Resolves #98516: This PR cleans up all the unused APIs exposed by the
telemetry
plugin and documents the exposed ones.When running
node scripts/build_api_docs --plugin telemetry --stats any --stats comments --stats exports
we still get the following warnings.This is because the current tool is not able to link the JSDocs and the methods declared as
const myFn = ({ destructVar }) => arrowFnResult
. However, hopefully, when we complete #93185, we'll be able to stop exposing those APIs.UPDATE: Setting
@internal
to those APIs solves the issue. Since they are only used internally by the X-Pack Telemetry extension, I think that's a good enough approach in this case 👍. Running the same command again, we get:Checklist
For maintainers