[Search Sessions] Split tasks #99967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
… session/cancellation
… session/cancellation
…\ expired async search
9 tasks
added 5 commits
June 10, 2021 17:21
… sessions/split-tasks
Dosant
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
Looks good to me and didn't notice any regressions, tested with fake shart delay agg focusing on expiration. Tested multi spaces.
I'd give @lukasolson a chance to review.
Also:
- There are a couple more redundant
anyusages forfilterI didn't point all of them in the previous review - This will need to be addressed (possibly OK after pr is merged): https://github.com/elastic/kibana/pull/99967/files#r648170897
- I this a bad merge? https://github.com/elastic/kibana/pull/99967/files#r648176354 pls review
x-pack/plugins/data_enhanced/server/search/session/get_search_session_page.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/data_enhanced/server/search/session/check_persisted_sessions.ts
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @lizozom |
lukasolson
approved these changes
Jun 24, 2021
| @@ -5,33 +5,28 @@ | |||
| * 2.0. | |||
There was a problem hiding this comment.
Nit: Rename to check_non_persisted_sessions.ts and check_non_persisted_sessions.test.ts
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 24, 2021
* cancel the previous session * split to 3 tasks * fixes * cancellation * updated tests * split out and improve jest tests * cleanup previous session properly * don't fail delete and cancel if item was already cleaned up * test * test * ignore resource_not_found_exception when deleting an already cleared \ expired async search * jest * update jest * api int * fix jest * testssss * Code review @Dosant * types * remove any * Fix merge * type * test * jest Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
Jun 28, 2021
* cancel the previous session * split to 3 tasks * fixes * cancellation * updated tests * split out and improve jest tests * cleanup previous session properly * don't fail delete and cancel if item was already cleaned up * test * test * ignore resource_not_found_exception when deleting an already cleared \ expired async search * jest * update jest * api int * fix jest * testssss * Code review @Dosant * types * remove any * Fix merge * type * test * jest Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Liza Katz <lizka.k@gmail.com> Co-authored-by: Liza K <liza.katz@elastic.co>
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #80406
Resolves #99967
Split out the search sesssion monitoring task into 3:
10s. (configurable bytrackingInterval)1m. (configurable bycleanupInterval)1h(Not configurable (should it be?))Checklist
Delete any items that are not applicable to this PR.
For maintainers