This repository has been archived by the owner on Sep 22, 2022. It is now read-only.
Xpack users roles creation #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you merge upstream/master with this? |
tsullivan
force-pushed
the
xpack-users-roles-creation
branch
from
32548a5 to
2fc8374
Compare
|
Done On March 3, 2016 at 12:59:17 PM, Chris Cowan (notifications@github.com) wrote: Can you merge upstream/master with this? — |
tsullivan
force-pushed
the
xpack-users-roles-creation
branch
from
2fc8374 to
096a18a
Compare
| return function (configPath) { | ||
| // append the shield/xpack directory to configPath | ||
| var usersConfig = semver.satisfies(version, '5.x || 3.x') ? 'xpack' : 'shield'; | ||
| configPath = path.join(configPath, usersConfig); |
There was a problem hiding this comment.
You should create a new variable here instead of just appending the usersConfig to this. When this function finally returns configPath it's now pointing to the wrong directory (which other functions depend on being set to the actual configPath)
tsullivan
force-pushed
the
xpack-users-roles-creation
branch
from
096a18a to
739c3d4
Compare
|
@simianhacker I updated the function so it doesn't change the configPath that gets returned. |
|
LGTM |
simianhacker
added a commit
that referenced
this pull request
Mar 16, 2016
Xpack users roles creation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating users in Elasticsearch 5.x / 3.x is different from previous versions because Shield is now an XPack feature. The config files for users are no longer
config/shield/users*they're nowconfig/xpack/users*