Changed implementation of clone method in SettingExt, previous was sh…

…allow copy now it's deep
elastic · Jan 12, 2021 · 68feccc · 68feccc
1 parent 280a95c
commit 68feccc
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/logstash-core/src/main/java/org/logstash/settings/SettingExt.java b/logstash-core/src/main/java/org/logstash/settings/SettingExt.java
@@ -35,7 +35,7 @@
 @JRubyClass(name = "Setting")
 public class SettingExt extends RubyObject {
 
-    private static final long serialVersionUID = 1L;
+    private static final long serialVersionUID = -4283509226931417677L;
 
     private ProxyJavaSetting setting;
 
@@ -309,9 +309,16 @@ public IRubyObject setDefault(ThreadContext context, IRubyObject rubyDefaultValu
 
     @JRubyMethod(name = "clone")
     public IRubyObject rubyClone(ThreadContext context) {
-        final SettingExt settingExt = new SettingExt(context.runtime, RubyUtil.SETTING_CLASS);
-        settingExt.setting = new ProxyJavaSetting(setting);
-        return settingExt;
+//        this doesn't work
+//        final SettingExt settingExt = new SettingExt(context.runtime, RubyUtil.SETTING_CLASS);
+//        settingExt.setting = new ProxyJavaSetting(setting);
+//        return settingExt;
+//        this works
+        try {
+            return (IRubyObject) this.clone();
+        } catch (CloneNotSupportedException ex) {
+            throw new RuntimeException(ex);
+        }
     }
 
     @JRubyMethod(name = "klass")