Removed @value field from Ruby Setting class, using the one from the …

…wrapped Java Setting class
elastic · May 27, 2024 · e688d12 · e688d12
1 parent 29748a8
commit e688d12
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/logstash-core/lib/logstash/settings.rb b/logstash-core/lib/logstash/settings.rb
@@ -255,7 +255,6 @@ def initialize(name, klass, default = nil, strict = true, &validator_proc)
 
       @klass = klass
       @validator_proc = validator_proc
-      @value = nil
 
       validate(default) if strict?
       @default = default
@@ -289,7 +288,7 @@ def strict?
     def set(value)
       validate(value) if strict?
       @wrapped_setting.set(value)
-      @value
+      @wrapped_setting.value
     end
 
     def reset
@@ -300,7 +299,7 @@ def to_hash
       {
         "name" => @wrapped_setting.name,
         "klass" => @klass,
-        "value" => @value,
+        "value" => @wrapped_setting.value,
         "value_is_set" => @wrapped_setting.set?,
         "default" => @default,
         # Proc#== will only return true if it's the same obj
@@ -368,7 +367,6 @@ def initialize(name, klass, default = nil, strict = true, &validator_proc)
 
         @klass = klass
         @validator_proc = validator_proc
-        @value = nil
 
         # needed to have the name method accessible when invoking validate
         @wrapped_setting = Java::org.logstash.settings.Setting.create(name)
@@ -817,9 +815,9 @@ def initialize(name, klass, default = nil)
       end
 
       def set(value)
-        @value = coerce(value)
-        @wrapped_setting.set(@value)
-        @value
+        coerced_value = coerce(value)
+        @wrapped_setting.set(coerced_value)
+        coerced_value
       end
 
       def coerce(value)