Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where is the "noop" filter ? #3493

Closed
duylong opened this issue Jun 23, 2015 · 7 comments
Closed

Where is the "noop" filter ? #3493

duylong opened this issue Jun 23, 2015 · 7 comments

Comments

@duylong
Copy link

duylong commented Jun 23, 2015

Hi,

Since my update to 1.5.x, I can't found the "noop" filter. Why this plugin has been deleted ?

Best regards,

@purbon
Copy link
Contributor

purbon commented Jun 23, 2015

@duylong you can find a replacement https://github.com/colinsurprenant/logstash-filter-noop, but I have a question for you, why do you need that filter?

@duylong
Copy link
Author

duylong commented Jun 23, 2015

I found more clean in order to use only (add|remove)_(field|tag).

@purbon
Copy link
Contributor

purbon commented Jun 23, 2015

interesting :-) thanks for sharing, so for now you will need to use @colinsurprenant code. hope this works for you. Should we close this for now?

@jordansissel
Copy link
Contributor

You can use mutate instead of noop filter

On Tuesday, June 23, 2015, Pere Urbón notifications@github.com wrote:

interesting :-) thanks for sharing, so for now you will need to use
@colinsurprenant https://github.com/colinsurprenant code. hope this
works for you. Should we close this for now?


Reply to this email directly or view it on GitHub
#3493 (comment).

@duylong
Copy link
Author

duylong commented Jun 23, 2015

@jordansissel Is it really his role?

@jordansissel
Copy link
Contributor

Background: The noop filter was written to aid in testing Logstash internally. All of the features the noop filter has are also supported by every other plugin. The mutate filter is the best replacement for any use of the noop filter because mutate will run add_field/etc on all events, not just some - contrast with date and grok filter which only activate add_field/etc for events which are successfully parsed.

Put shortly, any use of noop is literally replacable with the word mutate for the filter in your config, and it will work exactly the same. Any deviation of that is a bug.

@duylong
Copy link
Author

duylong commented Jun 25, 2015

I found more sense to have a plugin that does nothing for the understanding of the final code.

Thank you for your clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants