Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Watchdog in the code base #3828

Closed
ph opened this issue Sep 1, 2015 · 2 comments
Closed

Remove Watchdog in the code base #3828

ph opened this issue Sep 1, 2015 · 2 comments

Comments

@ph
Copy link
Contributor

ph commented Sep 1, 2015

The current implementation of the watchdog is buggy and unused, We should remove this dead code.
We will provide a better way of doing monitoring of the pipeline in #2611

ref #1512

@jordansissel
Copy link
Contributor

+1 removing the existing watchdog that is unused :)

For some background:

The watchdog was added early in Logstash's life because of execution problems with filters - there were certain filters (like grok with an exponential-runtime pattern) that could get stuck uninterruptably, and there was no way to recover without manual intervention. A watchdog was added to ensure no filter took more than 2 seconds of runtime, and if so, logstash would self-terminate (to avoid the required manual intervention).

The watchdog was broken in Logstash 1.2.0, and I recognized that fact soon after, but the report rate of "stuck filters" had, anecdotally, dropped to nearly zero, so I kind of just allowed the watchdog to continue not to function properly (it is not used since 1.2.0).

Given it's been a few years, and we are moving towards better visibility within the pipeline, I agree with this change.

@jordansissel
Copy link
Contributor

For a tangent, as part of the "grok regexp exponential oh my!" problem, I sent JRuby a patch to make Joni interruptable (via Thread.interrupt() in Java), so if we want to interrupt grok in the future, we have a way to do it without terminating logstash.

@ph ph added the v2.0.0 label Sep 1, 2015
ph added a commit to ph/logstash that referenced this issue Sep 1, 2015
This watchdog thread watching is currently unused and bugged in some
context, this PR remove any mention of it.

Ref elastic#3828
ph added a commit to ph/logstash that referenced this issue Sep 1, 2015
This watchdog thread watching is currently unused and bugged in some
context, this PR remove any mention of it.

Ref elastic#3828
@ph ph mentioned this issue Sep 1, 2015
ph added a commit that referenced this issue Sep 3, 2015
This watchdog thread watching is currently unused and bugged in some
context, this PR remove any mention of it.

Ref #3828

Fixes #3830
ph added a commit that referenced this issue Sep 3, 2015
This watchdog thread watching is currently unused and bugged in some
context, this PR remove any mention of it.

Ref #3828

Fixes #3830
@suyograo suyograo closed this as completed Sep 3, 2015
ph added a commit to ph/logstash that referenced this issue Sep 4, 2015
This watchdog thread watching is currently unused and bugged in some
context, this PR remove any mention of it.

Ref elastic#3828

Fixes elastic#3830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants