give multiple pipelines all the settings #11076
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we'd only give a pipeline the settings related to pipelines The PipelineSettings class was used for this. However a pipeline may need other settings like the keystore location. For this we instead clone the settings object and merge all the pipeline specific settings. This is accomplished with a new method that ensures that only pipeline level settings are overwritten in the clone.
jsvd
force-pushed
the
remove_pipeline_setttings_class
branch
from
94aa7cf to
86e0bac
Compare
|
Note that this resolves the root cause of #11055. |
|
@jsvd Does that mean that this statement that keystore is not supported when using |
For keystore/env vars to work on pipelines.yml we need #11081 |
elasticsearch-bot
pushed a commit
that referenced
this pull request
Aug 30, 2019
Previously we'd only give a pipeline the settings related to pipelines The PipelineSettings class was used for this. However a pipeline may need other settings like the keystore location. For this we instead clone the settings object and merge all the pipeline specific settings. This is accomplished with a new method that ensures that only pipeline level settings are overwritten in the clone. Fixes #11076
elasticsearch-bot
pushed a commit
that referenced
this pull request
Aug 30, 2019
Previously we'd only give a pipeline the settings related to pipelines The PipelineSettings class was used for this. However a pipeline may need other settings like the keystore location. For this we instead clone the settings object and merge all the pipeline specific settings. This is accomplished with a new method that ensures that only pipeline level settings are overwritten in the clone. Fixes #11076
elasticsearch-bot
pushed a commit
that referenced
this pull request
Aug 30, 2019
Previously we'd only give a pipeline the settings related to pipelines The PipelineSettings class was used for this. However a pipeline may need other settings like the keystore location. For this we instead clone the settings object and merge all the pipeline specific settings. This is accomplished with a new method that ensures that only pipeline level settings are overwritten in the clone. Fixes #11076
andsel
pushed a commit
to andsel/logstash
that referenced
this pull request
Sep 12, 2019
Previously we'd only give a pipeline the settings related to pipelines The PipelineSettings class was used for this. However a pipeline may need other settings like the keystore location. For this we instead clone the settings object and merge all the pipeline specific settings. This is accomplished with a new method that ensures that only pipeline level settings are overwritten in the clone. Fixes elastic#11076
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when creating pipelines from pipelines.yml,
we'd only give a pipeline the settings related to pipelines.
The PipelineSettings class was used for this.
However a pipeline may need other settings like the keystore location.
For this we instead clone the settings object and merge all the pipeline
specific settings. This is accomplished with a new method that ensures
that only pipeline level settings are overwritten in the clone.
To check that this patch works:
config/folder to/tmp/bin/logstash-keystore --path.settings /tmp/config createbin/logstash-keystore --path.settings /tmp/config add secretpipelines.ymlfile):bin/logstash --path.settings /tmp/config