Added plugin.name to fish tag log lines

[andsel]

Added the plugin's name to log lines generated by the plugins

---

This PR adds plugin.id to log lines.

Tipical use case:

• the user sees some log lines with plugin.id bring that id (running Java pipeline)
• query the LS Node Info API to get source reference in config file for that id (curl -XGET "localhost:9600/_node/pipelines/main?graph=true")

How to test

• run logstash with java pipeline, with debug log running the following pipeline.conf:

input {
  stdin {}
}

filter {
  json {
    source => "message"
  }
  sleep {
    id => "sleep_filter_123"
    time => 1
  }
}

output {
  stdout {
    codec => rubydebug
  }
}

bin/logstash -f "<config>" --java-execution=true --debug

• in console or in logs/logstash-plain.log you should find a line like:

[DEBUG][logstash.filters.json    ][main][31543d02478e75487017793958c743af64669fe5f915ab05695717240d026f49] Running json filter {:event=>#<LogStash::Event:0x2220404c>}

• bring that uuid and search in Node Into API with a rest call

[robbavey]

Looks good so far - can we add an integration test to show the plugin name logging works?

[andsel]

Ok I do it!

…

On Wed, Sep 4, 2019 at 3:29 PM Rob Bavey ***@***.***> wrote: ***@***.**** commented on this pull request. Looks good so far - can we add an integration test to show the plugin name logging works? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#11078?email_source=notifications&email_token=AAH5RUII4CCPZPVCX3EJAJTQH6Z4JA5CNFSM4IPA4P2KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDTZ55A#pullrequestreview-283614964>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAH5RUJJQ7SXSXUVQEMQRPDQH6Z4JANCNFSM4IPA4P2A> .

[andsel]

@robbavey this is done and ready to review

[robbavey]

I like the work done here in terms of how the extra information is added to log entries, but it might make sense to hold off on committing this PR until we have a more useful plugin.id and use that rather than include plugin.name.

My thoughts here are that plugin.name on its own may not be massively useful - the name does not unique identify plugins of the same type in a pipeline (or whether the plugin is an input, output, filter or codec), and often the log category already gives us sufficient context to do identify which plugin generated the log message (although this is less the case for more Java-centric plugins):

eg - this log entry created using a Logstash with this PR included:

[2019-09-20T10:42:05,574][INFO ][logstash.outputs.elasticsearch][main][elasticsearch] Retrying individual bulk actions that failed or were rejected by the previous bulk request. {:count=>2}

Thoughts @jsvd?

[robbavey]

Nit: Please remove comments

[andsel]

Fixed, thanks @robbavey.
I've also create an issue #11154 and a PR #11155 to start discussing a useful plugin.id or plugin.name

[robbavey]

Couple of nitpicks, but other than that, looks good!

[robbavey]

Nit: unused import

[andsel]

Done

[robbavey]

Nit: Unused import

[andsel]

Done

[robbavey]

LGTM

[elasticsearch-bot]

Andrea Selva merged this into the following branches!

Branch	Commits
master	6eb2517
7.x	7a22220