Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Remove include statements for screenshots not rendering properly #15981

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

karenzone
Copy link
Contributor

@karenzone karenzone commented Mar 7, 2024

Fixes: #15882

Screenshots are not rendering properly inside widgets. The widgets are documenting guided flows, and the screenshots are not critical for understanding. Note that I am not deleting the image files. They're still in place for when/if we decide to find a workaround and reimplement them.

PREVIEW: https://logstash_bk_15981.docs-preview.app.elstc.co/guide/en/logstash/master/dashboard-monitoring-with-elastic-agent.html

@karenzone
Copy link
Contributor Author

run docs-build

@karenzone karenzone marked this pull request as ready for review April 12, 2024 14:04
Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

--
[role="screenshot"]
image::../monitoring/images/integration-agent-add.png[Add agent flyout in {kib}]
--
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karenzone note to self: Note that you removed references, but did not delete image files from the repo

@karenzone karenzone merged commit cb45cd2 into elastic:main Apr 16, 2024
4 checks passed
@karenzone karenzone deleted the 15882-graphics branch April 16, 2024 21:25
@karenzone
Copy link
Contributor Author

@logstashmachine backport 8.13

@karenzone
Copy link
Contributor Author

6918

github-actions bot pushed a commit that referenced this pull request Apr 16, 2024
karenzone pushed a commit that referenced this pull request Apr 16, 2024
…#15981) (#16089)

(cherry picked from commit cb45cd2)
Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
@karenzone
Copy link
Contributor Author

@logstashmachine backport 8.14

github-actions bot pushed a commit that referenced this pull request Jun 28, 2024
karenzone added a commit that referenced this pull request Jun 28, 2024
…#15981) (#16269)

(cherry picked from commit cb45cd2)

Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc: Troubleshoot missing graphics in monitoring topics
3 participants