Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin rexml gem version to 3.2.6 #16209

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

edmocosta
Copy link
Contributor

Release notes

[rn:skip]

What does this PR do?

Pin rexml gem version to 3.2.6 as the newst releases are breaking the build/CI (to be investigated):

checking for onig_region_memsize() in ruby.h... *** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of necessary
libraries and/or headers.  Check the mkmf.log file for more details.  You may
need configuration options.

Provided configuration options:
	--with-opt-dir
	--without-opt-dir
	--with-opt-include
	--without-opt-include=${opt-dir}/include
	--with-opt-lib
	--without-opt-lib=${opt-dir}/lib
	--with-make-prog
	--without-make-prog
	--srcdir=.
	--curdir
	--ruby=/home/runner/work/logstash/logstash/vendor/jruby/bin/jruby
RuntimeError: The compiler failed to generate an executable file.
You have to install development tools first.

try_do at
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/mkmf.rb:456
try_link0 at
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/mkmf.rb:541
try_link at
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/mkmf.rb:556
try_func at
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/mkmf.rb:765
have_func at
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/mkmf.rb:1051
checking_for at
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/mkmf.rb:942
postpone at
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/mkmf.rb:350
open at
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/mkmf.rb:320
postpone at
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/mkmf.rb:350
open at
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/mkmf.rb:320
postpone at
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/mkmf.rb:346
checking_for at
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/mkmf.rb:941
have_func at
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/mkmf.rb:1050
        <main> at extconf.rb:4

To see why this extension failed to compile, please check the mkmf.log which can
be found here:

/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/gems/shared/extensions/universal-java-11/3.1.0/strscan-1.0.3/mkmf.log

extconf failed, exit code 1

Gem files will remain installed in
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/gems/shared/gems/strscan-1.0.3
for inspection.
Results logged to
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/gems/shared/extensions/universal-java-11/3.1.0/strscan-1.0.3/gem_make.out

/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/rubygems/ext/builder.rb:102:in
`run'
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/rubygems/ext/ext_conf_builder.rb:28:in
`build'
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/rubygems/ext/builder.rb:171:in
`build_extension'
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/rubygems/ext/builder.rb:205:in
`block in build_extensions'
  org/jruby/RubyArray.java:1981:in `each'
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/rubygems/ext/builder.rb:202:in
`build_extensions'
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/rubygems/installer.rb:843:in
`build_extensions'
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/bundler/rubygems_gem_installer.rb:72:in
`build_extensions'
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/bundler/rubygems_gem_installer.rb:28:in
`install'
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/bundler/source/rubygems.rb:207:in
`install'
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/bundler/installer/gem_installer.rb:54:in
`install'
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/bundler/installer/gem_installer.rb:16:in
`install_from_spec'
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/bundler/installer/parallel_installer.rb:186:in
`do_install'
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/bundler/installer/parallel_installer.rb:177:in
`block in worker_pool'
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/bundler/worker.rb:62:in
`apply_func'
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/bundler/worker.rb:57:in
`block in process_queue'
  org/jruby/RubyKernel.java:1722:in `loop'
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/bundler/worker.rb:54:in
`process_queue'
/home/runner/work/logstash/logstash/vendor/jruby/lib/ruby/stdlib/bundler/worker.rb:91:in
`block in create_threads'

An error occurred while installing strscan (1.0.3), and Bundler cannot continue.

In Gemfile:
  ci_reporter_rspec was resolved to 1.0.0, which depends on
    ci_reporter was resolved to 2.1.0, which depends on
      rexml was resolved to 3.2.9, which depends on
        strscan

@edmocosta edmocosta requested a review from andsel June 10, 2024 15:21
Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested locally and works smooth

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

@edmocosta edmocosta merged commit 23221ca into elastic:main Jun 10, 2024
6 checks passed
@edmocosta
Copy link
Contributor Author

@logstashmachine backport 8.14

github-actions bot pushed a commit that referenced this pull request Jun 10, 2024
This commit pinned the `rexml` gem version to `3.2.6`

(cherry picked from commit 23221ca)
edmocosta added a commit that referenced this pull request Jun 10, 2024
This commit pinned the `rexml` gem version to `3.2.6`

(cherry picked from commit 23221ca)

Co-authored-by: Edmo Vamerlatti Costa <11836452+edmocosta@users.noreply.github.com>
andsel pushed a commit to andsel/logstash that referenced this pull request Jul 12, 2024
This commit pinned the `rexml` gem version to `3.2.6`
robbavey added a commit that referenced this pull request Oct 15, 2024
This reverts commit 15098fb.

Don't update the license files, as we will pin rexml to `3.2.6` as we do in
main (see #16209)
edmocosta pushed a commit that referenced this pull request Oct 16, 2024
* Update patch plugin versions in gemfile lock

* Pin rexml to 3.2.6 to address compatibility issues with 3.2.9, as we do in main (see #16209)

---------

Co-authored-by: logstashmachine <43502315+logstashmachine@users.noreply.github.com>
Co-authored-by: Rob Bavey <rob.bavey@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants