Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pipeline bootstrap error logs #16495

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Improve pipeline bootstrap error logs #16495

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c680b6c
Added exception's cause on the pipeline converge state error logs
edmocosta Oct 2, 2024
8d78d00
Merge branch 'elastic:main' into add-error-cause-pipeline-converge-state
edmocosta Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion logstash-core/lib/logstash/agent.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,13 @@ def converge_state(pipeline_actions)
)
end
rescue SystemExit, Exception => e
logger.error("Failed to execute action", :action => action, :exception => e.class.name, :message => e.message, :backtrace => e.backtrace)
error_details = { :action => action, :exception => e.class.name, :message => e.message, :backtrace => e.backtrace }
cause = e.cause
if cause && e != cause
error_details[:cause] = { :exception => cause.class, :message => cause.message }
error_details[:cause][:backtrace] = cause.backtrace if cause.backtrace
end
logger.error('Failed to execute action', error_details)
converge_result.add(action, LogStash::ConvergeResult::FailedAction.from_exception(e))
end
end
Expand Down