ensure inputSize state value is reset during buftok.flush

[jsvd]

The BufferedTokenizer.flush must reset the inputSize value back to zero on flush, otherwise it will grow until a buffer full exception is thrown if the buffer has a size limit.

We can see the test fails if the inputSize = 0 is not present:

❯ bin/rspec logstash-core/spec/logstash/util/buftok_spec.rb -fd -e flush
[...]
FileWatch::BufferedTokenizer
  flush
    emits the contents of the buffer
    resets the state of the buffer
    with decode_size_limit_bytes
      resets the state of the buffer (FAILED - 1)
      emits the contents of the buffer

Failures:

  1) FileWatch::BufferedTokenizer flush with decode_size_limit_bytes resets the state of the buffer
     Failure/Error: expect(subject).to be_empty
       expected `#<FileWatch::BufferedTokenizer:0x35977ba7>.empty?` to be truthy, got false
     # ./logstash-core/spec/logstash/util/buftok_spec.rb:65:in `block in <main>'
     # ./spec/spec_helper.rb:84:in `block in <main>'

But with it tests pass:

❯ bin/rspec logstash-core/spec/logstash/util/buftok_spec.rb -fd -e flush

FileWatch::BufferedTokenizer
  flush
    resets the state of the buffer
    emits the contents of the buffer
    with decode_size_limit_bytes
      emits the contents of the buffer
      resets the state of the buffer

Finished in 0.0246 seconds (files took 1.34 seconds to load)
4 examples, 0 failures

closes #16762

[elastic-sonarqube]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 7f90eef

[yaauie]

👍🏼 this change does actually fix the issue where inputSize is not reset on a flush.

[yaauie]

LGTM to fix.

[yaauie]

@logstashmachine backport 8.x 8.17 8.16

[EDIT: the bot doesn't like multiple branches in a single comment]

[yaauie]

@logstashmachine backport 8.x

[yaauie]

@logstashmachine backport 8.17

[yaauie]

@logstashmachine backport 8.16