Backport PR #16786 to 8.x: Avoid lock when ecs_compatibility is explicitly specified #16828
+4
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #16786 to 8.x branch, original message:
Release notes
ecs_compatibility
directive.What does this PR do?
Properly memoizes an explicitly-given
ecs_compatibility
directive on first access so that it can be retrieved without lock contention.Because a
break
escapes abegin
...end
block, we must not use abreak
in order to ensure that the explicitly set value gets memoized to avoid lock contention.Note: no
FAKE_SYNC:return
:Why is it important/What is the impact to the user?
Eliminates unnecessary lock contention, which can prevent some plugins from running as concurrently as they would otherwise be able.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)[ ] I have added tests that prove my fix is effective or that my feature worksHow to test this PR locally
Related issues
Use cases
Screenshots
Logs