lib: add sprintf helper function #75
Conversation
efd6
added
enhancement
| } | ||
| args = append(args, v) | ||
| } | ||
| return types.String(fmt.Sprintf(string(format), args...)) |
There was a problem hiding this comment.
Since in L#1095: format, ok := arg0.(types.String) we already asserted the format is a string, is it required to convert it again in L#1113?
There was a problem hiding this comment.
We assert it to a types.String which is a named type with a underlying type string. We cannot use a type.String in the place of a string since although they have the same underlying type, the spec only allows assignment between different types without conversion if one of the types is not named. This is detailed in the Assignability section of the spec.
V and T have identical underlying types but are not type parameters and at least one of V or T is not a named type.
The situation in the use of the types.Int in the make call is less constrained because make's integer arguments are not specified to be int, but rather builtin.IntegerType.
Please take a look.