-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[synthetics] Incorporate lightweight monitors more thoroughly into docs #2073
Conversation
A documentation preview will be available soon: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with having this page, I just didn't fully understand what you wish to include in each section.
IMO we could also break that page down into multiple sub-pages to cover the specific options for each type of monitor. IMO that would make it easier for users to find the information they want.
It's also worth noticing that although you updated the "browser" titles here, the overall section title in the docs is still "uptime and synthetic monitoring", so I think we should change it there as well to be consistent.
[[uptime-lightweight-monitors]] | ||
= Use lightweight monitors | ||
|
||
// What do we want to say about lightweight monitors? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO the main difference between these and browser monitors is that there isn't a browser environment that needs to be spun-up. Therefore, these are usually quicker.
[discrete] | ||
== Configure a monitor | ||
|
||
// List all options? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there will be plenty of common options for us to list together, so perhaps we could start with the "common required options", then move on to the options that are specific for each monitor, and then list "common options" (the remaining non-required ones).
== Create a monitor | ||
|
||
// Options are available in the set up guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this section a bit redundant considering the previous "configure a monitor" section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies -- meant to be the lightweight equivalent of Create a browser monitor, but if there's not enough to say specifically for lightweight monitors (like there is for browser monitors) then we can remove it.
== Manage monitors | ||
|
||
// How to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand what you mean by manage. Is it editing and deleting them? Or is it managing the results (i.e. viewing results and debugging)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meant to be the lightweight equivalent of Manage browser monitors, but if there's not enough to say specifically for lightweight monitors (like there is for browser monitors) then we can remove it.
Ok. I'll give this a try and we can see what it looks like!
"Uptime and synthetic monitoring" attempts to signal to readers that this section contains information about the "Uptime" UI in Kibana, but also the industry term "synthetic monitors". 🤷♀️ Do you think that is still important? |
@colleenmcginnis that's a good question. I think just changing "synthetic monitors" to maybe "synthetic monitoring" could help as that names the practice rather than the type of monitors ("browser monitors"), but in that case I wonder whether the change is even worth doing given it's so small. I don't think anyone would notice in that case tbh. In any case, I'm not strongly opinionated about that. |
Note: I'm going to hold on this until #2075 is finalized. (I didn't anticipate that other PR impacting the changes here initially, but the changes overlap.) |
This pull request is now in conflict. Could you fix it @colleenmcginnis? 🙏
|
Background
@andrewvc @lucasfcosta and I met a couple weeks ago to discuss synthetics docs issues. One issue that came up was incorporating more lightweight monitor content throughout the docs.
Overview
This PR proposes to:
To do