Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[synthetics] Incorporate lightweight monitors more thoroughly into docs #2073

Closed
wants to merge 2 commits into from

Conversation

colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Aug 10, 2022

⚠️ Note: This is a work in progress.

Background

@andrewvc @lucasfcosta and I met a couple weeks ago to discuss synthetics docs issues. One issue that came up was incorporating more lightweight monitor content throughout the docs.

Overview

This PR proposes to:

  • Continue to keep browser-specific content separate from lightweight monitor content because users have to learn significantly more concepts to implement browser monitors. We should make it easy to implement lightweight monitors without sifting through content that is only relevant to browser monitors.
  • Reframes existing titles of browser-specific content like "Use synthetic monitors" to be more specific: "Use browser monitors".
  • Adds a "Use lightweight monitors" page that can act as an equivalent to "Use browser monitors". Note: I'm not sure what level of detail to include here yet.

To do

@colleenmcginnis colleenmcginnis added backport-8.9 Automated backport with mergify backport-8.4 Automated backport with mergify labels Aug 10, 2022
@colleenmcginnis colleenmcginnis self-assigned this Aug 10, 2022
@apmmachine
Copy link
Contributor

apmmachine commented Aug 10, 2022

A documentation preview will be available soon:

Copy link
Contributor

@lucasfcosta lucasfcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with having this page, I just didn't fully understand what you wish to include in each section.

IMO we could also break that page down into multiple sub-pages to cover the specific options for each type of monitor. IMO that would make it easier for users to find the information they want.

It's also worth noticing that although you updated the "browser" titles here, the overall section title in the docs is still "uptime and synthetic monitoring", so I think we should change it there as well to be consistent.

[[uptime-lightweight-monitors]]
= Use lightweight monitors

// What do we want to say about lightweight monitors?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the main difference between these and browser monitors is that there isn't a browser environment that needs to be spun-up. Therefore, these are usually quicker.

[discrete]
== Configure a monitor

// List all options?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there will be plenty of common options for us to list together, so perhaps we could start with the "common required options", then move on to the options that are specific for each monitor, and then list "common options" (the remaining non-required ones).

Comment on lines +28 to +30
== Create a monitor

// Options are available in the set up guide
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this section a bit redundant considering the previous "configure a monitor" section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies -- meant to be the lightweight equivalent of Create a browser monitor, but if there's not enough to say specifically for lightweight monitors (like there is for browser monitors) then we can remove it.

Comment on lines +33 to +35
== Manage monitors

// How to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand what you mean by manage. Is it editing and deleting them? Or is it managing the results (i.e. viewing results and debugging)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to be the lightweight equivalent of Manage browser monitors, but if there's not enough to say specifically for lightweight monitors (like there is for browser monitors) then we can remove it.

@colleenmcginnis
Copy link
Contributor Author

IMO we could also break that page down into multiple sub-pages to cover the specific options for each type of monitor. IMO that would make it easier for users to find the information they want.

Ok. I'll give this a try and we can see what it looks like!

It's also worth noticing that although you updated the "browser" titles here, the overall section title in the docs is still "uptime and synthetic monitoring", so I think we should change it there as well to be consistent.

"Uptime and synthetic monitoring" attempts to signal to readers that this section contains information about the "Uptime" UI in Kibana, but also the industry term "synthetic monitors". 🤷‍♀️ Do you think that is still important?

@lucasfcosta
Copy link
Contributor

lucasfcosta commented Aug 11, 2022

"Uptime and synthetic monitoring" attempts to signal to readers that this section contains information about the "Uptime" UI in Kibana, but also the industry term "synthetic monitors". 🤷‍♀️ Do you think that is still important?

@colleenmcginnis that's a good question. I think just changing "synthetic monitors" to maybe "synthetic monitoring" could help as that names the practice rather than the type of monitors ("browser monitors"), but in that case I wonder whether the change is even worth doing given it's so small. I don't think anyone would notice in that case tbh.

In any case, I'm not strongly opinionated about that.

@colleenmcginnis
Copy link
Contributor Author

Note: I'm going to hold on this until #2075 is finalized. (I didn't anticipate that other PR impacting the changes here initially, but the changes overlap.)

@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2022

This pull request is now in conflict. Could you fix it @colleenmcginnis? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b uptime-vocab upstream/uptime-vocab
git merge upstream/main
git push upstream uptime-vocab

@colleenmcginnis colleenmcginnis added 8.5-candidate Team:Uptime Label for the Uptime team Area:Synthetics Synthetics Docs Issue labels Sep 29, 2022
@colleenmcginnis
Copy link
Contributor Author

Closing in favor of #2372 and #2353

@colleenmcginnis colleenmcginnis deleted the uptime-vocab branch December 1, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.5-candidate Area:Synthetics Synthetics Docs Issue backport-8.4 Automated backport with mergify backport-8.9 Automated backport with mergify Team:Uptime Label for the Uptime team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants