Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fleet/Agent release notes for 8.5 #2264

Merged
merged 7 commits into from
Oct 28, 2022
Merged

Add Fleet/Agent release notes for 8.5 #2264

merged 7 commits into from
Oct 28, 2022

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Oct 12, 2022 •
edited
Loading

Closes #2227

  • Add Fleet release notes. REVIEW READY
  • Add Fleet Server release notes. REVIEW READY
  • Add Elastic Agent release notes. REVIEW READY
  • Add https://github.com/elastic/elastic-agent/pull/1552 if it gets into the final build.

Link to preview: https://observability-docs_2264.docs-preview.app.elstc.co/guide/en/fleet/master/release-notes-8.5.0.html

Questions for reviewers:

  • This changelog entry was not covered in the fragments but is in the commit history. Keep it? "Use the Elastic Agent configuration directory as the root of the inputs.d folder #663 #840"
  • Is the edit I made here correct? "Custom server limits are no longer ignored when default limits are loaded #1841 #1912" (The original changelog entry didn't make sense to me: "LoadServerLimits will not overwrite specified limits when loading default/agent number specified values")
  • Can we improve the following entry to explain why this change is important to users? "Use separate rate limiters for internal and external API listeners #1859 #1904" How about saying this instead: "Use separate rate limiters for internal and external API listeners to prevent Fleet Server from shutting down under load."

@dedemorton dedemorton self-assigned this Oct 12, 2022
@apmmachine
Copy link
Contributor

apmmachine commented Oct 12, 2022 •
edited
Loading

A documentation preview will be available soon:

@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2022

This pull request does not have a backport label. Could you fix it @dedemorton? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 12, 2022
@dedemorton
Copy link
Contributor Author

Marking this as "ready for review" for the Fleet and Fleet Server parts only.

@dedemorton dedemorton marked this pull request as ready for review October 17, 2022 23:32
@dedemorton dedemorton added backport-8.5 Automated backport with mergify Team:Fleet Label for the Fleet team and removed backport-skip Skip notification from the automated backport with mergify labels Oct 17, 2022
@dedemorton dedemorton requested review from a team, michalpristas and blakerouse and removed request for a team October 18, 2022 20:47
@cmacknz cmacknz self-requested a review October 19, 2022 14:34
@cmacknz
Copy link
Member

cmacknz commented Oct 19, 2022

To answer your questions:

This changelog entry was not covered in the fragments but is in the commit history. Keep it? "Use the Elastic Agent configuration directory as the root of the inputs.d folder elastic/elastic-agent#663 elastic/elastic-agent#840"

Yes, keep it. It was lost in the conversion to changelog fragments. Thanks for catching this.

Is the edit I made here correct? "Custom server limits are no longer ignored when default limits are loaded elastic/fleet-server#1841 elastic/fleet-server#1912" (The original changelog entry didn't make sense to me: "LoadServerLimits will not overwrite specified limits when loading default/agent number specified values")

Yes, this is clearer. Thanks!

Can we improve the following entry to explain why this change is important to users? "Use separate rate limiters for internal and external API listeners elastic/fleet-server#1859 elastic/fleet-server#1904" How about saying this instead: "Use separate rate limiters for internal and external API listeners to prevent Fleet Server from shutting down under load."

Same here, this is clearer than the original. Thanks!

kpollich
kpollich approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet notes LGTM

@dedemorton dedemorton merged commit d89a1ed into elastic:main Oct 28, 2022
@dedemorton dedemorton deleted the add_8.5_relnotes branch October 28, 2022 22:42
mergify bot pushed a commit that referenced this pull request Oct 28, 2022
@dedemorton @mergify
Add Fleet/Agent release notes for 8.5 (#2264)
fb57eaf 
(cherry picked from commit d89a1ed)
@mergify mergify bot mentioned this pull request Oct 28, 2022
Merged
dedemorton added a commit that referenced this pull request Oct 29, 2022
@mergify @dedemorton
Add Fleet/Agent release notes for 8.5 (#2264) (#2300)
30cfc97 
(cherry picked from commit d89a1ed)

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
bmorelli25 pushed a commit to bmorelli25/observability-docs that referenced this pull request Apr 11, 2023
@dedemorton
Add Fleet/Agent release notes for 8.5 (elastic#2264)
bbff02e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlind23 jlind23 jlind23 approved these changes

@kpollich kpollich kpollich approved these changes

@cmacknz cmacknz cmacknz approved these changes

@michalpristas michalpristas Awaiting requested review from michalpristas michalpristas was automatically assigned from elastic/elastic-agent-control-plane

@blakerouse blakerouse Awaiting requested review from blakerouse blakerouse was automatically assigned from elastic/elastic-agent-control-plane

@pierrehilbert pierrehilbert Awaiting requested review from pierrehilbert

Assignees

@dedemorton dedemorton

Labels
backport-8.5 Automated backport with mergify Team:Fleet Label for the Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request] Create release notes for Fleet/Agent in 8.5
5 participants
@dedemorton @apmmachine @cmacknz @kpollich @jlind23