Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode fields in Kibana objects if not encoded #506

Merged
merged 3 commits into from
Jun 10, 2020

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Jun 10, 2020

Issue: #466 (comment)

This PR modifies the generator code to encode fields that are not encoded. If they are encoded, it leaves them as is.

@mtojek mtojek requested a review from ruflin June 10, 2020 14:51
@mtojek mtojek self-assigned this Jun 10, 2020
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems like the tests show that if it is decoded, encoding still works as not generated files were updated. Lets hope the other part also works ;-)

"pod": "kubernetes.pod.uid",
"tiebreaker": "_doc",
"timestamp": "@timestamp"
"infrastructure-ui-source" : {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why it reordered this one 🤔

Copy link
Contributor Author

@mtojek mtojek Jun 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally cleaned up the source here. There are no differences in the content.

@elasticmachine
Copy link

elasticmachine commented Jun 10, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #506 updated]

  • Start Time: 2020-06-10T14:52:51.993+0000

  • Duration: 9 min 56 sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants